fix: replace eval() with new Function() in setEdgeNodeValidator to pr…#331
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 20, 2026
Merged
Conversation
Author
|
Hey @pradeeban when would be the best time for you to review proposals? Also, for the proposal format you shared, do you want me to follow it strictly line by line, or is it fine if I add a bit of extra context where needed? I’ve learned a lot from your feedback so far, so I want to align with your preferred format and don't want to deviate if you prefer it as-is. |
Member
|
@avinxshKD you can share the proposal draft in a single email to all three of the mentors. Fine to have extra content. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307
setEdgeNodeValidator was calling eval() directly on user-supplied validator strings, which meant anyone sharing a graph with a malicious validator could run arbitrary JS in the victim's browser. Swapped to new Function() which keeps the execution out of the local scope no access to this, imports, or closure variables.