Is there any reason why we don't requeue events when HTTP request fails, eg. due to lost internet connection ?
|
void FAptabaseAnalyticsProvider::OnEventsRecoded(FHttpRequestPtr Request, FHttpResponsePtr Response, bool bWasSuccessful, TArray<FAptabaseEventPayload> OriginalEvents) |
|
{ |
|
if (!bWasSuccessful) |
|
{ |
|
UE_LOG(LogAptabase, Error, TEXT("Request to record the event was unsuccessful.")); |
|
return; |
|
} |
Shouldn't we call BatchedEvents.Append(OriginalEvents); here?
@pasotee
Is there any reason why we don't requeue events when HTTP request fails, eg. due to lost internet connection ?
aptabase-unreal/Source/Aptabase/Private/AptabaseAnalyticsProvider.cpp
Lines 204 to 210 in 1a2171d
Shouldn't we call
BatchedEvents.Append(OriginalEvents);here?@pasotee