Skip to content

Commit 4fa821a

Browse files
authored
Add secret store csi and FSx CSI smoke tests to addon suite (#802)
1 parent cc18782 commit 4fa821a

File tree

1 file changed

+20
-31
lines changed

1 file changed

+20
-31
lines changed

test/e2e/suite/addons/addons_test.go

Lines changed: 20 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -403,25 +403,20 @@ var _ = Describe("Hybrid Nodes", func() {
403403

404404
Context("runs Secrets Store CSI driver tests", func() {
405405
It("uses all OS", func(ctx context.Context) {
406-
_, err := addonEc2Test.NewSecretsStoreCSIDriverTest(ctx)
406+
secretsStoreTest, err := addonEc2Test.NewSecretsStoreCSIDriverTest(ctx)
407407
Expect(err).To(Succeed(), "should have created secrets store CSI driver test")
408408

409-
// Comment out the below code when the add-on is available publicly on aws console
410-
411-
// secretsStoreTest, err := addonEc2Test.NewSecretsStoreCSIDriverTest(ctx)
412-
// Expect(err).To(Succeed(), "should have created secrets store CSI driver test")
413-
414-
// DeferCleanup(func(ctx context.Context) {
415-
// Expect(secretsStoreTest.Delete(ctx)).To(Succeed(), "should cleanup Secrets Store CSI driver successfully")
416-
// })
409+
DeferCleanup(func(ctx context.Context) {
410+
Expect(secretsStoreTest.Delete(ctx)).To(Succeed(), "should cleanup Secrets Store CSI driver successfully")
411+
})
417412

418-
// Expect(secretsStoreTest.Create(ctx)).To(
419-
// Succeed(), "Secrets Store CSI driver should have been created successfully",
420-
// )
413+
Expect(secretsStoreTest.Create(ctx)).To(
414+
Succeed(), "Secrets Store CSI driver should have been created successfully",
415+
)
421416

422-
// Expect(secretsStoreTest.Validate(ctx)).To(
423-
// Succeed(), "Secrets Store CSI driver should have been validated successfully",
424-
// )
417+
Expect(secretsStoreTest.Validate(ctx)).To(
418+
Succeed(), "Secrets Store CSI driver should have been validated successfully",
419+
)
425420
})
426421
}, Label("secrets-store-csi-driver"))
427422

@@ -446,26 +441,20 @@ var _ = Describe("Hybrid Nodes", func() {
446441

447442
Context("runs FSx CSI driver tests", func() {
448443
It("uses all OS", func(ctx context.Context) {
449-
_, err := addonEc2Test.NewFsxCSIDriverTest(ctx)
444+
fsxCSITest, err := addonEc2Test.NewFsxCSIDriverTest(ctx)
450445
Expect(err).To(Succeed(), "should have created FSx CSI driver test")
451446

452-
// Comment out the below code when the add-on is available publicly on aws console
453-
454-
// fsxCSITest, err := addonEc2Test.NewFsxCSIDriverTest(ctx)
455-
456-
// Expect(err).To(Succeed(), "should have created FSx CSI driver test")
457-
458-
// DeferCleanup(func(ctx context.Context) {
459-
// Expect(fsxCSITest.Delete(ctx)).To(Succeed(), "should cleanup FSx CSI driver successfully")
460-
// })
447+
DeferCleanup(func(ctx context.Context) {
448+
Expect(fsxCSITest.Delete(ctx)).To(Succeed(), "should cleanup FSx CSI driver successfully")
449+
})
461450

462-
// Expect(fsxCSITest.Create(ctx)).To(
463-
// Succeed(), "FSx CSI driver should have been created successfully",
464-
// )
451+
Expect(fsxCSITest.Create(ctx)).To(
452+
Succeed(), "FSx CSI driver should have been created successfully",
453+
)
465454

466-
// Expect(fsxCSITest.Validate(ctx)).To(
467-
// Succeed(), "FSx CSI driver should have been validated successfully",
468-
// )
455+
Expect(fsxCSITest.Validate(ctx)).To(
456+
Succeed(), "FSx CSI driver should have been validated successfully",
457+
)
469458
})
470459
}, Label("fsx-csi-driver"))
471460
})

0 commit comments

Comments
 (0)