Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThis pull request removes Lens network references across documentation and configuration files. Changes include deletion of Lens entries from contract address tables, supported network lists, API endpoints, fee configurations, and token address tables, plus removal of the Lens explorer entry from the contract-addresses component. Changes
Poem
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Danziger
commented
Mar 11, 2026
| The exposed endpoint provided must be of the following format: {base_url}/\${envName}/\${network} - for example: https://api.mysolver.io/staging/mainnet | ||
| envName values: shadow, staging, prod | ||
| supported networks: arbitrum-one, avalanche, base, bnb, lens, linea, mainnet, polygon, xdai (gnosis) and more are coming out! | ||
| supported networks: arbitrum-one, avalanche, base, bnb, mainnet, xdai (gnosis), ink, linea, optimism, polygon, sepolia, and more are coming out! |
Contributor
Author
There was a problem hiding this comment.
Some where missing here.
Contributor
There was a problem hiding this comment.
Indeed, Plasma is also missing!
alfetopito
approved these changes
Mar 11, 2026
| The exposed endpoint provided must be of the following format: {base_url}/\${envName}/\${network} - for example: https://api.mysolver.io/staging/mainnet | ||
| envName values: shadow, staging, prod | ||
| supported networks: arbitrum-one, avalanche, base, bnb, lens, linea, mainnet, polygon, xdai (gnosis) and more are coming out! | ||
| supported networks: arbitrum-one, avalanche, base, bnb, mainnet, xdai (gnosis), ink, linea, optimism, polygon, sepolia, and more are coming out! |
Contributor
There was a problem hiding this comment.
Indeed, Plasma is also missing!
Danziger
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/cow-protocol/reference/contracts/periphery/README.mdx (1)
17-18: Consider extracting the duplicated EthFlow network list into a single constant.The same chain array appears twice; centralizing it reduces future drift when chain support changes.
♻️ Suggested refactor
+const ETHFLOW_NETWORKS = [ + "Ethereum","Gnosis","Arbitrum One","Base","Avalanche", + "Polygon","BNB","Linea","Plasma","Ink","Sepolia" +] + | Environment | Address | Networks | | ------------------------ | -------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| Production (all chains) | `0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeC` | {explorerLinks(["Ethereum","Gnosis","Arbitrum One","Base","Avalanche","Polygon","BNB","Linea","Plasma","Ink","Sepolia"], "0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeC")} | -| Staging (all chains) | `0x04501b9b1D52e67f6862d157E00D13419D2D6E95` | {explorerLinks(["Ethereum","Gnosis","Arbitrum One","Base","Avalanche","Polygon","BNB","Linea","Plasma","Ink","Sepolia"], "0x04501b9b1D52e67f6862d157E00D13419D2D6E95")} | +| Production (all chains) | `0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeC` | {explorerLinks(ETHFLOW_NETWORKS, "0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeC")} | +| Staging (all chains) | `0x04501b9b1D52e67f6862d157E00D13419D2D6E95` | {explorerLinks(ETHFLOW_NETWORKS, "0x04501b9b1D52e67f6862d157E00D13419D2D6E95")} |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/cow-protocol/reference/contracts/periphery/README.mdx` around lines 17 - 18, The duplicated chain array used in the two explorerLinks(...) calls should be extracted into a single constant (e.g., const ethFlowChains = [...]) and referenced in both places to avoid drift; update the two lines that call explorerLinks(["Ethereum","Gnosis",...,"Sepolia"], "<address>") to call explorerLinks(ethFlowChains, "<address>") so explorerLinks is invoked with the single shared array for both the Production and Staging entries (addresses `0xbA3cB449...0EAdeC` and `0x04501b...D6E95`).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/cow-protocol/reference/contracts/core/README.mdx`:
- Around line 47-49: The docs list Optimism and Plasma in the explorerLinks
arrays for GPv2Settlement, GPv2AllowListAuthentication, and GPv2VaultRelayer but
those deployments are not found; either verify deployment records and keep the
networks or remove "Optimism" and "Plasma" from the explorerLinks arrays for the
three entries (`GPv2Settlement`, `GPv2AllowListAuthentication`,
`GPv2VaultRelayer`) and update the corresponding explorerLinks invocation so
only confirmed networks remain visible, ensuring the displayed chain list
matches actual deployment evidence.
---
Nitpick comments:
In `@docs/cow-protocol/reference/contracts/periphery/README.mdx`:
- Around line 17-18: The duplicated chain array used in the two
explorerLinks(...) calls should be extracted into a single constant (e.g., const
ethFlowChains = [...]) and referenced in both places to avoid drift; update the
two lines that call explorerLinks(["Ethereum","Gnosis",...,"Sepolia"],
"<address>") to call explorerLinks(ethFlowChains, "<address>") so explorerLinks
is invoked with the single shared array for both the Production and Staging
entries (addresses `0xbA3cB449...0EAdeC` and `0x04501b...D6E95`).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 85ad7961-37fc-4e9a-adb4-9654a231d3ce
📒 Files selected for processing (14)
docs/cow-amm/tutorials/cow-amm-deployer.mddocs/cow-amm/tutorials/cow-amm-for-solvers.mddocs/cow-protocol/reference/contracts/core/README.mdxdocs/cow-protocol/reference/contracts/periphery/README.mdxdocs/cow-protocol/reference/core/auctions/bonding_pools.mddocs/cow-protocol/reference/core/auctions/competition_rules.mddocs/cow-protocol/reference/core/auctions/rewards.mddocs/cow-protocol/reference/core/signing_schemes.mdxdocs/cow-protocol/tutorials/cow-swap/custom-links.mddocs/cow-protocol/tutorials/solvers/local_test.mddocs/cow-protocol/tutorials/solvers/onboard.mddocs/cow-protocol/tutorials/widget/widget.mddocs/governance/token.mdsrc/components/contract-addresses/index.tsx
💤 Files with no reviewable changes (11)
- docs/cow-amm/tutorials/cow-amm-deployer.md
- docs/cow-protocol/reference/core/auctions/competition_rules.md
- src/components/contract-addresses/index.tsx
- docs/cow-protocol/tutorials/cow-swap/custom-links.md
- docs/governance/token.md
- docs/cow-protocol/reference/core/auctions/rewards.md
- docs/cow-protocol/reference/core/auctions/bonding_pools.md
- docs/cow-amm/tutorials/cow-amm-for-solvers.md
- docs/cow-protocol/tutorials/widget/widget.md
- docs/cow-protocol/tutorials/solvers/local_test.md
- docs/cow-protocol/reference/core/signing_schemes.mdx
Comment on lines
+47
to
+49
| | [`GPv2Settlement`](core/settlement)<br />Upgradeable: No ❎<br />[GitHub](https://github.com/cowprotocol/contracts/blob/main/src/contracts/GPv2Settlement.sol) | `0x9008D19f58AAbD9eD0D60971565AA8510560ab41`<br />{explorerLinks(["Arbitrum One","Avalanche","Base","BNB","Ethereum","Gnosis","Ink","Linea","Optimism","Plasma","Polygon","Sepolia",], "0x9008D19f58AAbD9eD0D60971565AA8510560ab41", {separator: <br />})} | | ||
| | [`GPv2AllowListAuthentication`](core/allowlist)<br />Upgradeable: Yes ⚠️<br />[GitHub](https://github.com/cowprotocol/contracts/blob/main/src/contracts/GPv2AllowListAuthentication.sol) | `0x2c4c28DDBdAc9C5E7055b4C863b72eA0149D8aFE`<br />{explorerLinks(["Arbitrum One","Avalanche","Base","BNB","Ethereum","Gnosis","Ink","Linea","Optimism","Plasma","Polygon","Sepolia",], "0x2c4c28DDBdAc9C5E7055b4C863b72eA0149D8aFE", {separator: <br />})} | | ||
| | [`GPv2VaultRelayer`](core/vault-relayer)<br />Upgradeable: No ❎<br />[GitHub](https://github.com/cowprotocol/contracts/blob/main/src/contracts/GPv2VaultRelayer.sol) | `0xC92E8bdf79f0507f65a392b0ab4667716BFE0110`<br />{explorerLinks(["Arbitrum One","Avalanche","Base","BNB","Ethereum","Gnosis","Ink","Linea","Optimism","Plasma","Polygon","Sepolia",], "0xC92E8bdf79f0507f65a392b0ab4667716BFE0110", {separator: <br />})} | |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify contract deployments on Optimism and Plasma
echo "Checking GPv2Settlement (0x9008D19f58AAbD9eD0D60971565AA8510560ab41):"
echo "Optimism:"
curl -s "https://api-optimistic.etherscan.io/api?module=contract&action=getabi&address=0x9008D19f58AAbD9eD0D60971565AA8510560ab41" | jq -r '.status, .message'
echo -e "\nPlasma:"
curl -s "https://api.plasmascan.to/api?module=contract&action=getabi&address=0x9008D19f58AAbD9eD0D60971565AA8510560ab41" | jq -r '.status, .message'
echo -e "\nChecking GPv2AllowListAuthentication (0x2c4c28DDBdAc9C5E7055b4C863b72eA0149D8aFE):"
echo "Optimism:"
curl -s "https://api-optimistic.etherscan.io/api?module=contract&action=getabi&address=0x2c4c28DDBdAc9C5E7055b4C863b72eA0149D8aFE" | jq -r '.status, .message'
echo -e "\nPlasma:"
curl -s "https://api.plasmascan.to/api?module=contract&action=getabi&address=0x2c4c28DDBdAc9C5E7055b4C863b72eA0149D8aFE" | jq -r '.status, .message'
echo -e "\nChecking GPv2VaultRelayer (0xC92E8bdf79f0507f65a392b0ab4667716BFE0110):"
echo "Optimism:"
curl -s "https://api-optimistic.etherscan.io/api?module=contract&action=getabi&address=0xC92E8bdf79f0507f65a392b0ab4667716BFE0110" | jq -r '.status, .message'
echo -e "\nPlasma:"
curl -s "https://api.plasmascan.to/api?module=contract&action=getabi&address=0xC92E8bdf79f0507f65a392b0ab4667716BFE0110" | jq -r '.status, .message'Repository: cowprotocol/docs
Length of output: 391
Revert Optimism and Plasma additions pending deployment confirmation.
The chain list changes are structurally sound, but verification shows the contracts are not found on Optimism and Plasma explorer APIs. The documentation should only list chains where contracts are actually deployed to avoid misleading users.
Either confirm these contracts are deployed on Optimism and Plasma through deployment records, or remove those chains from the lists until deployment is confirmed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/cow-protocol/reference/contracts/core/README.mdx` around lines 47 - 49,
The docs list Optimism and Plasma in the explorerLinks arrays for
GPv2Settlement, GPv2AllowListAuthentication, and GPv2VaultRelayer but those
deployments are not found; either verify deployment records and keep the
networks or remove "Optimism" and "Plasma" from the explorerLinks arrays for the
three entries (`GPv2Settlement`, `GPv2AllowListAuthentication`,
`GPv2VaultRelayer`) and update the corresponding explorerLinks invocation so
only confirmed networks remain visible, ensuring the displayed chain list
matches actual deployment evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed support for Lens network and added Optimism to some places where it wasn't mentioned.
Summary by CodeRabbit