Skip to content

'logical_sector' Argument Nomenclature Issue #67

@nflandin

Description

@nflandin

LevelX has a number of functions and variables containing the word 'sector' which I believe to mis-named. Notably, all the functions containing "..._nand_flash_sector..." actually work on flash "page(s)". Additionally, these functions all have an argument named "logical_sector", which has nothing to do with a filesystem sector, creating even more confusion.

I suggest that all the functions named "..._nand_flash_sector..." be renamed to "...nand_flash_page...", and that the arguments named "logical_sector" be re-named to "logical_page", or something to that effect. Arguments named "sector count" could be renamed to "page_count". This would make writing drivers significantly less confusing.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Discussion

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions