Modernize type annotations: PEP 604 and collections.abc imports#4912
Closed
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Closed
Modernize type annotations: PEP 604 and collections.abc imports#4912saitcakmak wants to merge 1 commit intofacebook:mainfrom
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93275514. |
…book#4912) Summary: Pull Request resolved: facebook#4912 Modernize type annotations across Ax (open-source and ax/fb): - Replace `Optional[X]` with `X | None` and `Union[X, Y]` with `X | Y` (PEP 604). - Move `Callable`, `Sequence`, `Mapping`, and `Iterable` imports from `typing` to `collections.abc`. - Remove unused `typing` imports where they become empty. Pure annotation changes with no behavioral impact. Files that use `Union` at runtime (e.g., with `assert_is_instance`) are left unchanged. Reviewed By: Balandat Differential Revision: D93275514
saitcakmak
force-pushed
the
export-D93275514
branch
from
aa48480 to
ca9d094
Compare
|
This pull request has been merged in 983c00c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Modernize type annotations across Ax (open-source and ax/fb):
Optional[X]withX | NoneandUnion[X, Y]withX | Y(PEP 604).Callable,Sequence,Mapping, andIterableimports fromtypingtocollections.abc.typingimports where they become empty.Pure annotation changes with no behavioral impact. Files that use
Unionat runtime (e.g., withassert_is_instance) are left unchanged.Reviewed By: Balandat
Differential Revision: D93275514