[🐛] v24 new typescript interface not working

[fracico-tech]

Issue

After upgrading to v24 and following Migrating to v24, TypeScript reports Type 'DocumentSnapshot' is not generic' when using the root export DocumentSnapshot in type positions that expect the generic Firestore types (e.g. DocumentSnapshot<DocumentData> or compatibility with other v24 modular typings).

Minimal pattern that fails:

import { DocumentSnapshot, DocumentData } from '@react-native-firebase/firestore';
function f(_snap: DocumentSnapshot<DocumentData>) {}

other patterns

function (t: Transaction,
tRef: DocumentReference) {
t.update(tRef, ticket);
}
Argument of type 'DocumentReference<DocumentData, DocumentData>' is not assignable to parameter of type 'DocumentReference'.
  Type 'DocumentReference<DocumentData, DocumentData>' is missing the following properties from type 'DocumentReference': _firestore, _documentPath, _converter, collection, and 6 more

package.json:

    "@react-native-firebase/ai": "24.0.0",
    "@react-native-firebase/app": "24.0.0",
    "@react-native-firebase/app-check": "24.0.0",
    "@react-native-firebase/auth": "24.0.0",
    "@react-native-firebase/crashlytics": "24.0.0",
    "@react-native-firebase/firestore": "24.0.0",
    "@react-native-firebase/functions": "24.0.0",
    "@react-native-firebase/installations": "24.0.0",
    "@react-native-firebase/messaging": "24.0.0",
    "@react-native-firebase/storage": "24.0.0",
    "react": "19.2.3",
    "react-native": "0.85.1",

Environment

Click To Expand

react-native info output:

System:
  OS: macOS 26.4.1
  CPU: (10) arm64 Apple M2 Pro
  Memory: 174.88 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.14.0
    path: /Users/francescoclementi/.nvm/versions/node/v22.14.0/bin/node
  Yarn:
    version: 3.6.4
    path: /usr/local/bin/yarn
  npm:
    version: 10.9.2
    path: /Users/francescoclementi/.nvm/versions/node/v22.14.0/bin/npm
  Watchman:
    version: 2025.04.28.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/francescoclementi/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 25.4
      - iOS 26.4
      - macOS 26.4
      - tvOS 26.4
      - visionOS 26.4
      - watchOS 26.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2025.1 AI-251.26094.121.2513.14007798
  Xcode:
    version: 26.4/17E192
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /Users/francescoclementi/.jenv/shims/javac
  Ruby:
    version: 2.7.4
    path: /Users/francescoclementi/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 20.1.0
    wanted: 20.1.0
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.85.1
    wanted: 0.85.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true

• react-native-firebase version you're using that has this issue:
  • 24.0.0

---

• 👉 Check out React Native Firebase and Invertase on Twitter for updates on the library.

[wneel]

Hi @fracico-tech,

Since the below code without using DocumentSnapshot as a generic works fine can you share an example where you need the generic ?

	function f(_snap: DocumentSnapshot) {}

Following the SDK guidelines I was able to fix all errors I got during type migration by moving type definition in the queries (query) or the collection calls,

Here is my wrapper :

const genericConverter = <T>(): FirestoreDataConverter<T, DocumentData> => ({
	toFirestore: (data: T): DocumentData => data as DocumentData,
	fromFirestore: (snapshot: QueryDocumentSnapshot<DocumentData>): T => snapshot.data() as T
});

export const getCollection = <T>(path: string) => collection(firestore, path).withConverter(genericConverter<T>());

Please share a real example you are facing, maybe moving up the type definition will do the trick as it did for me!

[russellwheatley]

Hey @fracico-tech - do you want to point your firestore package to this branch: #8989, and let me know if it resolves your issue?