Presently, we create the HCS document in the service layer and then pass that along to the VM Controller in Create call.
|
hcsDocument, sandboxOptions, err := lcow.BuildSandboxConfig(ctx, ShimName, request.BundlePath, shimOpts, &sandboxSpec) |
This also leaks other VM options such as confidential, etc into service layer which can be encapsulated within the VM Controller.
Basically, service sends the specs to vmController.Create. It calls the LCOW or WCOW tagged file to generate the HCS document and sandbox options which it stores internally. Next during Start it references the same to create Confidential stack.
For other cases such as Network controller etc, it can use the same.
Presently, we create the HCS document in the service layer and then pass that along to the VM Controller in Create call.
hcsshim/cmd/containerd-shim-lcow-v2/service/service_sandbox_internal.go
Line 74 in 799fe74
This also leaks other VM options such as confidential, etc into service layer which can be encapsulated within the VM Controller.
Basically, service sends the specs to
vmController.Create. It calls the LCOW or WCOW tagged file to generate the HCS document and sandbox options which it stores internally. Next during Start it references the same to create Confidential stack.For other cases such as Network controller etc, it can use the same.