feat(cli): Obligation trigger commit by c-r33d · Pull Request #3306 · opentdf/platform

c-r33d · 2026-04-15T03:21:35Z

Proposed Changes

1.) Add implementation for migrating obligation triggers

Checklist

I have added or updated unit tests
I have added or updated integration tests (if appropriate)
I have added or updated documentation

Testing Instructions

coderabbitai · 2026-04-15T03:21:42Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 94440dfa-0473-473d-af5c-5d8b3687022a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch commit-obligations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2026-04-15T03:21:51Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the necessary infrastructure and logic to support the migration of obligation triggers within the namespaced policy migration tool. It extends the existing executor framework to handle the creation and validation of these triggers, ensuring they are correctly applied across namespaces while maintaining consistency with existing migration patterns.

Highlights

Obligation Trigger Migration: Implemented the core logic for migrating obligation triggers, including the execution flow and target creation.
Executor Interface Update: Added the CreateObligationTrigger method to the ExecutorHandler interface to support the new migration functionality.
Testing and Validation: Added comprehensive unit tests for obligation trigger execution, covering various scenarios including successful creation, existing targets, and error handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

The triggers wait in silent rows, As code through migration flows. With tests in place to guard the gate, We seal the policy's new fate.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request implements the execution logic for obligation triggers within the namespaced policy migration. Key changes include adding the CreateObligationTrigger method to the ExecutorHandler interface, implementing the execution flow in obligation_triggers_execute.go, and adding comprehensive unit tests. Review feedback recommends renaming a loop variable to avoid shadowing the context package and removing an internal 'TODO' comment in the test helpers.

github-actions · 2026-04-15T03:27:05Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	154.673418ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	69.459181ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	337.281432ms
Throughput	296.49 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	32.703322215s
Average Latency	325.902241ms
Throughput	152.89 requests/second

github-actions · 2026-04-15T03:34:36Z

X-Test Results

✅ go-pull-3306
✅ java-pull-3306
✅ go-v0.9.0
✅ js-pull-3306
✅ java-v0.9.0
test-cases-mapping-report
bats-test-results
✅ js-v0.9.0
cukes-report
opentdf~~platform~~1O10D3.dockerbuild
govulncheck-failure-5
govulncheck-failure-3
govulncheck-failure-8
govulncheck-failure-2
govulncheck-failure-0
govulncheck-failure-1

github-actions · 2026-04-15T03:39:50Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	190.430977ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	101.570742ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	400.052551ms
Throughput	249.97 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	40.922098422s
Average Latency	407.731342ms
Throughput	122.18 requests/second

github-actions · 2026-04-15T03:47:01Z

X-Test Results

✅ go-pull-3306
✅ go-v0.9.0
✅ java-pull-3306
✅ java-v0.9.0
✅ js-pull-3306
✅ js-v0.9.0
test-cases-mapping-report
bats-test-results
cukes-report
opentdf~~platform~~84DEN4.dockerbuild
govulncheck-failure-8
govulncheck-failure-3
govulncheck-failure-2
govulncheck-failure-1
govulncheck-failure-0
govulncheck-failure-5

alkalescent

lgtm

Invalidated by push of 2902a03

github-actions · 2026-04-15T17:54:44Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	152.167366ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	82.104253ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	381.783094ms
Throughput	261.93 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.415333793s
Average Latency	392.210201ms
Throughput	126.85 requests/second

github-actions · 2026-04-15T17:56:46Z

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

examples
otdfctl
sdk
service
lib/fixtures
tests-bdd

See the workflow run for details.

github-actions · 2026-04-15T18:02:30Z

X-Test Results

✅ go-pull-3306
✅ go-v0.9.0
✅ java-pull-3306
✅ js-pull-3306
✅ java-v0.9.0
✅ js-v0.9.0
test-cases-mapping-report
bats-test-results
cukes-report
opentdf~~platform~~MWWMEL.dockerbuild
govulncheck-failure-2
govulncheck-failure-8
govulncheck-failure-3
govulncheck-failure-0
govulncheck-failure-1
govulncheck-failure-5

c-r33d requested a review from a team as a code owner April 15, 2026 03:21

github-actions bot added the size/m label Apr 15, 2026

gemini-code-assist bot reviewed Apr 15, 2026

View reviewed changes

Comment thread otdfctl/migrations/namespacedpolicy/obligation_triggers_execute.go Outdated

Comment thread otdfctl/migrations/namespacedpolicy/execute_test_helpers_test.go

c-r33d added 2 commits April 15, 2026 12:40

feat(cli): Obligation trigger commit

1cac0cd

comments.

62a804e

alkalescent previously approved these changes Apr 15, 2026

View reviewed changes

fix tests.

2902a03

c-r33d force-pushed the commit-obligations branch from 8ca838b to 2902a03 Compare April 15, 2026 17:49

alkalescent approved these changes Apr 15, 2026

View reviewed changes

c-r33d merged commit 9febda1 into DSPX-2655-migrate-otdfctl Apr 15, 2026
35 checks passed

c-r33d deleted the commit-obligations branch April 15, 2026 18:05

Conversation

c-r33d commented Apr 15, 2026

Proposed Changes

Checklist

Testing Instructions

Uh oh!

coderabbitai bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

gemini-code-assist bot commented Apr 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Apr 15, 2026

X-Test Results

Uh oh!

github-actions bot commented Apr 15, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Apr 15, 2026

X-Test Results

Uh oh!

alkalescent left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 15, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Apr 15, 2026

⚠️ Govulncheck found vulnerabilities ⚠️

Uh oh!

github-actions bot commented Apr 15, 2026

X-Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Apr 15, 2026 •

edited

Loading