Fix install script failing when piped in a login shell

Author: begelundmuller

scripts/install.sh

@@ -43,18 +43,28 @@ checkGitDependency() {
     fi
 }
 
-# Ensure that either 'shasum' or 'sha256sum' is installed and executable, exit and print help message if not
+# Ensure that either 'shasum' or 'sha256sum' is installed and executable, exit and print help message if not.
+# Sets SHA256_CMD to the resolved command name for use by sha256Verify.
 resolveShasumDependency() {
     if [ -x "$(command -v shasum)" ]; then
-        sha256_verify="shasum --algorithm 256 --ignore-missing --check"
+        SHA256_CMD="shasum"
     elif [ -x "$(command -v sha256sum)" ]; then
-        sha256_verify="sha256sum --ignore-missing --check"
+        SHA256_CMD="sha256sum"
     else
         printf "neither 'shasum' or 'sha256sum' could be found, this script depends on one of them, please install one of them and try again.\n"
         exit 1
     fi
 }
 
+# Verify a checksums file using the resolved SHA256 command
+sha256Verify() {
+    if [ "$SHA256_CMD" = "shasum" ]; then
+        shasum --algorithm 256 --ignore-missing --check "$1"
+    else
+        sha256sum --ignore-missing --check "$1"
+    fi
+}
+
 # Download the binary and check the integrity using the SHA256 checksum
 downloadBinary() {
     CDN="cdn.rilldata.com"
@@ -66,20 +76,22 @@ downloadBinary() {
     BINARY_URL="https://${CDN}/rill/${VERSION}/rill_${PLATFORM}.zip"
     CHECKSUM_URL="https://${CDN}/rill/${VERSION}/checksums.txt"
 
+    printf "Downloading binary: %s\n" "$BINARY_URL"
     if [ "$NON_INTERACTIVE" = "true" ]; then
-        set -- "--silent" "--show-error"
+        curl --location --silent --show-error "${BINARY_URL}" --output rill_${PLATFORM}.zip
     else
-        set -- "--progress-bar"
+        curl --location --progress-bar "${BINARY_URL}" --output rill_${PLATFORM}.zip
     fi
 
-    printf "Downloading binary: %s\n" "$BINARY_URL"
-    curl --location "$@" "${BINARY_URL}" --output rill_${PLATFORM}.zip
-
     printf "\nDownloading checksum: %s\n" "$CHECKSUM_URL"
-    curl --location "$@" "${CHECKSUM_URL}" --output checksums.txt
+    if [ "$NON_INTERACTIVE" = "true" ]; then
+        curl --location --silent --show-error "${CHECKSUM_URL}" --output checksums.txt
+    else
+        curl --location --progress-bar "${CHECKSUM_URL}" --output checksums.txt
+    fi
 
     printf "\nVerifying the SHA256 checksum of the downloaded binary:\n"
-    ${sha256_verify} checksums.txt
+    sha256Verify checksums.txt
 
     printf "\nUnpacking rill_%s.zip\n" "$PLATFORM"
     unzip -q rill_${PLATFORM}.zip
@@ -185,7 +197,7 @@ publishSyftEvent() {
     SYFT_URL=https://event.syftdata.com/log
     SYFT_ID=clp76quhs0006l908bux79l4v
     if [ -z "$RILL_INSTALL_DISABLE_TELEMETRY" ]; then
-        curl --silent --show-error --header "Authorization: ${SYFT_ID}" --header "Content-Type: application/json" --data "{\"event_name\":\"$1\"}" $SYFT_URL > /dev/null || true >&2
+        curl --silent --show-error --header "Authorization: ${SYFT_ID}" --header "Content-Type: application/json" --data "{\"event_name\":\"$1\"}" $SYFT_URL > /dev/null 2>&1 || true
     fi
 }
 
@@ -328,23 +340,11 @@ set -e
 # Default values
 INSTALL_DIR_EXPLICIT=false
 
-# Default to non-interactive if STDIN is not a terminal (usually indicates e.g. agent, CI, subprocess).
-# Backwards compatibility: Old versions of `rill upgrade` didn't pass STDIN through, so we stay interactive if the parent process is named `rill`.
-if ! [ -t 0 ]; then
-    # Get parent process name
-    PARENT_NAME=""
-    if [ -n "$PPID" ]; then
-        if [ -f "/proc/$PPID/comm" ]; then
-            PARENT_NAME=$(basename "$(cat "/proc/$PPID/comm" 2>/dev/null)" 2>/dev/null)
-        elif command -v ps >/dev/null 2>&1; then
-            PARENT_NAME=$(basename "$(ps -o comm= -p "$PPID" 2>/dev/null)" 2>/dev/null)
-        fi
-    fi
-
-    # Apply the default
-    if [ "$PARENT_NAME" != "rill" ]; then
-        NON_INTERACTIVE=${NON_INTERACTIVE:-true}
-    fi
+# Default to non-interactive if /dev/tty is not available (e.g. CI, Docker, headless environments).
+# We check /dev/tty rather than stdin because the script may be piped (curl | sh) while a
+# terminal is still available for user prompts (which read from /dev/tty).
+if ! [ -w /dev/tty ] 2>/dev/null; then
+    NON_INTERACTIVE=${NON_INTERACTIVE:-true}
 fi
 NON_INTERACTIVE=${NON_INTERACTIVE:-false}