Skip to content

style(core): fmt import#1137

Merged
0x676e67 merged 1 commit intomainfrom
style
Apr 10, 2026
Merged

style(core): fmt import#1137
0x676e67 merged 1 commit intomainfrom
style

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@0x676e67 0x676e67 changed the title style(core): fmt export style(core): fmt import Apr 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase to improve consistency and performance. Key changes include updating the Result type alias to support a default error type, simplifying imports by renaming IncomingBody to Incoming, and removing the ClientTransaction alias. Additionally, several methods were marked with #[inline], constants were moved to more local scopes, and the HTTP/2 client builder was refactored. Review feedback suggests further utilizing the updated Result alias across various files to replace more verbose std::result::Result declarations.

I am having trouble creating individual review comments. Click here to see my feedback.

src/client/core/conn/http1.rs (140)

medium

Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.

    ) -> impl Future<Output = Result<Response<Incoming>, TrySendError<Request<B>>>>

src/client/core/conn/http2.rs (126)

medium

Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.

    ) -> impl Future<Output = Result<Response<Incoming>, TrySendError<Request<B>>>>

src/client/core/proto/http2/client.rs (131)

medium

Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.

    type Output = Result<(), http2::Error>;

src/client/core/proto/http2/client.rs (171)

medium

Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.

    type Output = Result<(), ()>;

src/client/core/proto/http2/client.rs (491)

medium

Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.

    type Output = Result<Response<body::Incoming>, (Error, Option<Request<B>>)>;

@0x676e67 0x676e67 merged commit df7e758 into main Apr 10, 2026
42 of 46 checks passed
@0x676e67 0x676e67 deleted the style branch April 10, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant