Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to improve consistency and performance. Key changes include updating the Result type alias to support a default error type, simplifying imports by renaming IncomingBody to Incoming, and removing the ClientTransaction alias. Additionally, several methods were marked with #[inline], constants were moved to more local scopes, and the HTTP/2 client builder was refactored. Review feedback suggests further utilizing the updated Result alias across various files to replace more verbose std::result::Result declarations.
I am having trouble creating individual review comments. Click here to see my feedback.
src/client/core/conn/http1.rs (140)
Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.
) -> impl Future<Output = Result<Response<Incoming>, TrySendError<Request<B>>>>
src/client/core/conn/http2.rs (126)
Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.
) -> impl Future<Output = Result<Response<Incoming>, TrySendError<Request<B>>>>
src/client/core/proto/http2/client.rs (131)
Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.
type Output = Result<(), http2::Error>;
src/client/core/proto/http2/client.rs (171)
Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.
type Output = Result<(), ()>;
src/client/core/proto/http2/client.rs (491)
Since Result is now imported from crate::client::core and has been updated to support a custom error type as its second parameter, you can use it here instead of the more verbose std::result::Result.
type Output = Result<Response<body::Incoming>, (Error, Option<Request<B>>)>;
No description provided.