Skip to content

chore: Split apply_block#1872

Draft
sergerad wants to merge 3 commits intorelease/v0.13from
sergerad-instrument-apply-block
Draft

chore: Split apply_block#1872
sergerad wants to merge 3 commits intorelease/v0.13from
sergerad-instrument-apply-block

Conversation

@sergerad
Copy link
Copy Markdown
Collaborator

@sergerad sergerad commented Apr 1, 2026

Splits the apply_block fn to add more instrumentation

rpc [ 3.48ms | 0.00% / 100.00% ] rpc.service: "store.BlockProducer" | rpc.method: "ApplyBlock"
┕━ apply_block [ 3.48ms | 0.00% / 100.00% ]
   ┝━ validate_block_header [ 1.43ms | 41.18% ]
   ┝━ compute_tree_mutations [ 1.14ms | 32.69% ]
   ┝━ build_note_records [ 12.5µs | 0.36% ]
   ┝━ store.block_store.save_block [ 63.2µs | 1.82% ] block_num: BlockNumber(8) | block_size: 357
   ┝━ await_db_readiness [ 12.2µs | 0.35% ]
   ┝━ acquire_inner_write_lock [ 9.62µs | 0.28% ]
   ┝━ apply_block [ 802µs | 13.59% / 23.06% ]
   │  ┝━ insert_block_header [ 88.3µs | 2.54% ]
   │  ┝━ upsert_accounts [ 5.08µs | 0.15% ]
   │  ┝━ insert_scripts [ 18.3µs | 0.53% ]
   │  ┝━ insert_notes [ 14.6µs | 0.42% ]
   │  ┝━ insert_transactions [ 13.4µs | 0.38% ]
   │  ┝━ insert_nullifiers_for_block [ 71.5µs | 2.06% ]
   │  ┕━ acquire_write_lock [ 118µs | 3.40% ]
   ┝━ acquire_forest_write_lock [ 9.12µs | 0.26% ]
   ┕━ i [info]: apply_block successful | block_commitment:

@sergerad sergerad added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better thanks, I'm leaving a review now since I'll be on leave soon.

If we can get this in, and then investigate why things are slow that would be fantastic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants