Do not store mtp_losses/mtp_acceptance in state params#3130
Open
bvandermoon wants to merge 1 commit intomainfrom
Open
Do not store mtp_losses/mtp_acceptance in state params#3130bvandermoon wants to merge 1 commit intomainfrom
bvandermoon wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cgarciae
reviewed
Feb 12, 2026
cgarciae
reviewed
Feb 12, 2026
c4b10f8 to
14e9c69
Compare
14e9c69 to
ad257bb
Compare
parambole
approved these changes
Feb 13, 2026
Collaborator
parambole
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the quick fix.
ad257bb to
76cfa15
Compare
76cfa15 to
18ed9ee
Compare
parambole
approved these changes
Feb 14, 2026
Collaborator
parambole
left a comment
There was a problem hiding this comment.
Thank you for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mtp_lossesandmtp_acceptanceas part of params. This was causing a checkpoint loading error because they are not stored as part of the checkpoints.FIXES: b/483723849
Tests
Successfully ran the XPK workload in the linked bug with checkpoint loading.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.