Open
Conversation
- fix updating UncaughtExceptionReporter for Scheduler backed by ScheduledThreadPoolExecutor - fix updating UncaughtExceptionReporter for WrappedSchedulers - fix error reporting for wrapped schedulers
08da14a to
ee75b3b
Compare
…ceptionReporter override is present
f640223 to
f064b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In JDK 25
ForkJoinPoolimplementsScheduledExecutorService. This change resulted in incorrect error reporting and failing tests in #6.Problem
Monix has two internal implementations of
ExecutorScheduler:FromSimpleExecutor- for regularExecutorServiceFromScheduledExecutor- forScheduledExecutorServiceThe
FromScheduledExecutorimplementation relies on error reporting being done by the underlying executor itself (viaafterExecutehook), but this only works correctly withAdaptedThreadPoolExecutor(Monix's custom implementation). For otherScheduledExecutorServiceimplementations, error reporting did not work properly.Before JDK 25 this problem wasn't visible, because almost all
Schedulerfactory methods useAsyncScheduler,FromSimpleExecutororFromScheduledExecutortogether withAdaptedThreadPoolExecutor.Additionally,
withUncaughtExceptionReporterdidn't work correctly for all scheduler methods in wrapped schedulers (AsyncScheduler, etc.) - the updated reporter wasn't being used forscheduleOnce,scheduleAtFixedRate, andscheduleWithFixedDelay.Changes
Restricted
FromScheduledExecutor(nowFromAdaptedThreadPoolExecutor) usage - This implementation is now only used for schedulers backed byAdaptedScheduledThreadPoolExecutor. All otherExecutorServiceimplementations (includingScheduledExecutorServiceandForkJoinPool) useFromSimpleExecutor.Fixed error reporting in wrapped schedulers (
ReferenceScheduler) - ThescheduleOnce,scheduleAtFixedRate, andscheduleWithFixedDelaymethods now wrap runnables withInterceptRunnableto pass exceptions to correct reporters.