Extract Rocq strings to OCaml strings #571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cters Native string extraction is now supported by all the Coq versions we support.
…ring` No longer needed now that strings extract to strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the
stringtype of Rocq/Coq was extracted to thechar listtype of OCaml, with conversion functions defined in lib/Coqlib.ml.Extraction of Rocq/Coq strings to OCaml native strings (type
string) was introduced in Coq 8.13 and has been stable since Coq 8.15, which is the oldest version CompCert supports.This PR activates the extraction to OCaml native strings and removes the uses of the Coqlib string conversion functions, which are now unnecessary. This makes the OCaml code of CompCert a bit cleaner and probably a bit faster too.