Skip to content

Add retroreflective to specular BSDFs#2783

Open
msuzuki-nvidia wants to merge 8 commits intoAcademySoftwareFoundation:mainfrom
msuzuki-nvidia:add-retroreflective
Open

Add retroreflective to specular BSDFs#2783
msuzuki-nvidia wants to merge 8 commits intoAcademySoftwareFoundation:mainfrom
msuzuki-nvidia:add-retroreflective

Conversation

@msuzuki-nvidia
Copy link
Contributor

Add a retroreflective boolean input to the specular BSDF nodes (dielectric_bsdf, conductor_bsdf, generalized_schlick_bsdf).

  • Update the PBR specification with the new input
  • Add retroreflective input to node definitions in pbrlib_defs.mtlx
  • Add GLSL implementation. OSL and MDL have interface-only changes (the parameter is ignored)

Also includes minor test infrastructure fixes:

  • Make FilePath::createDirectory() recursive to support nested output directories
  • Resolve relative paths to absolute in OslRenderer before working directory changes
  • Skip blur.mtlx in MDL render tests due to material name mismatch

Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, @msuzuki-nvidia, and I'd like to aim to include it in MaterialX v1.39.5 if possible.

Let's get additional feedback from others in the physically based shading community and see how it looks to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants