Skip to content

Add check for buffer bound#55

Open
raz-adroll wants to merge 11 commits intomainfrom
fix_buffer_size
Open

Add check for buffer bound#55
raz-adroll wants to merge 11 commits intomainfrom
fix_buffer_size

Conversation

@raz-adroll
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@abijr abijr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for when the buffer is out of bounds, validate that we're emitting the error correctly?

@raz-adroll
Copy link
Copy Markdown
Collaborator Author

Can we add a test for when the buffer is out of bounds, validate that we're emitting the error correctly?

Unfortunately, I don't have enough memory for that.
What I suspect is that at some point, it was trying to access invalid memory and that was giving us an invalid memory size.
How that happened is unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants