Skip to content

MID: remove input wildcards in MID workflows#15049

Open
ehellbar wants to merge 1 commit intoAliceO2Group:devfrom
ehellbar:pr15049
Open

MID: remove input wildcards in MID workflows#15049
ehellbar wants to merge 1 commit intoAliceO2Group:devfrom
ehellbar:pr15049

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Feb 10, 2026

No description provided.

@ehellbar ehellbar requested review from a team and shahor02 as code owners February 10, 2026 16:07
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar
Copy link
Collaborator Author

ehellbar commented Feb 10, 2026

this is to guarantee that expected inputs (subspecs) are processed together, which worked by chance with the old DPL early forwarding (where all inputs / subspecs usually arrived together), but is not necessarily the case with the new early forwarding.

For some devices which anyway only use the Standard EventType, we only define that as input, while other devices will receive all three EventTypes, or only the calib data.

In any case, for me it looked like it is clear which input subspecs are supposed to be there, but please cross-check and give feedback.

Here, I only checked the reco workflows, I should probably also check the others?

@alibuild
Copy link
Collaborator

alibuild commented Feb 10, 2026

Error while checking build/O2/fullCI_slc9 for 1621666 at 2026-02-11 10:30:

## sw/BUILD/O2-sim-challenge-test-latest/log
./midreco.log[15188:MIDFiltering]: [10:30:14][ERROR] Exception while running: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist. Rethrowing.
./midreco.log[15188:MIDFiltering]: [10:30:14][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./midreco.log[ERROR] Workflow crashed - PID 15188 (MIDFiltering) did not exit correctly however it's not clear why. Exit code forced to 128.
./midreco.log[ERROR]  - Device MIDFiltering: pid 15188 (exit 128)
./midreco.log[INFO]    - First error: [10:30:14][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./midreco.log[ERROR] SEVERE: Device MIDFiltering (15188) had at least one message above severity 7: Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./sim-challenge.logDetected critical problem in logfile midreco.log
./sim-challenge.logmidreco.log:[15188:MIDFiltering]: [10:30:14][ERROR] Exception while running: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist. Rethrowing.
./sim-challenge.logmidreco.log-[15188:MIDFiltering]: [10:30:14][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./sim-challenge.log[15188:MIDFiltering]: [10:30:14][ERROR] Exception while running: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist. Rethrowing.
./sim-challenge.log[15188:MIDFiltering]: [10:30:14][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./sim-challenge.log[ERROR] Workflow crashed - PID 15188 (MIDFiltering) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device MIDFiltering: pid 15188 (exit 128)
./sim-challenge.log[INFO]    - First error: [10:30:14][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./sim-challenge.log[ERROR] SEVERE: Device MIDFiltering (15188) had at least one message above severity 7: Unhandled o2::framework::runtime_error reached the top of main of o2-mid-reco-workflow, device shutting down. Reason: InputRecord::get: no input with binding mid_filter_in_labels found. Available inputs: mid_filter_in_0, mid_filter_in_labels_0, mid_filter_in_rof_0, mid_bad_channels, mid_rejectlist
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7628:TPCDigitizer_11]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7251:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7338:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7338:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7338:TPCDigitizer_0]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
[0 more errors; see full log]

Full log here.

@ehellbar
Copy link
Collaborator Author

I adjusted also the data getters and removed the subspec from the MClabel binding

@lmassacr
Copy link
Contributor

Hi @dstocco,
Can you look also give a look at this PR?

@ehellbar ehellbar force-pushed the pr15049 branch 2 times, most recently from 538ee03 to 93b6eec Compare February 11, 2026 14:29
@alibuild
Copy link
Collaborator

alibuild commented Feb 12, 2026

Error while checking build/O2/fullCI_slc9 for 93b6eec at 2026-02-12 08:56:

## sw/BUILD/O2-RTC-test-latest/log
[ERROR] Error Opening cagpu library for GPU Tracker (libO2GPUTrackingCUDA.so)
[ERROR] Error: Could not load GPUReconstruction for specified device: CUDA (2)

Full log here.

@ehellbar
Copy link
Collaborator Author

I put back the subSpec for the MC labels input to also avoid wildcarded MC labels input

@ehellbar
Copy link
Collaborator Author

ehellbar commented Feb 13, 2026

together with these changes, we should also put the subspec to the inputs of the MIDDigits QC task (https://github.com/AliceO2Group/QualityControl/blob/b61f5cab3c0e495ad6332966545446c58ba3aa12/Modules/MUON/MID/src/DigitsQcTask.cxx#L144) in the QC jsons (in QC, O2DPG and consul gitlab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants