[PWGEM,PWGEM-36] PhotonMeson: photonResoTask bug fixes and full mc pa… #14896
+230
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rticle for EMCal - Changed the EM MC particles for EMCal to store all of them not just the largest contribution, so we have them for further studies. Espacially in AA collisions important. - Fix a bug how the V0 were cut in `photonResoTask.cxx` by using the wrong template argument - Fix a bug in the `IsConversionPointInAcceptance` which did not properly checked for in the acceptance. Some < and > were wrong and it checked for the true photon production vertex instead of the true legs production vertex, which effectively cutted out 99% of all photons - Remove some `iteratorAt()` function calls and replaced them with iterators that are created once and then moved by using `setCursor()`. - Remove some not needed includes - Format some includes (<> instead of "" for external includes) - Add usage of `PDG_t` and `Pdg` enums in modified files to make the code more readable, unless you already know all the PDG codes ;)
mhemmer-cern
requested review from
alibuild,
dsekihat,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
alibuild
approved these changes
Feb 10, 2026
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
Collaborator
Author
|
Hello @ktf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rticle for EMCal
photonResoTask.cxxby using the wrong template argumentIsConversionPointInAcceptancewhich did not properly checked for in the acceptance. Some < and > were wrong and it checked for the true photon production vertex instead of the true legs production vertex, which effectively cutted out 99% of all photonsiteratorAt()function calls and replaced them with iterators that are created once and then moved by usingsetCursor(). This should reduce CPU time, sinceiteratorAt()always creates a new instance of an iterator and then callssetCursor()itself. Now the number of iterator creations is much smaller than before.PDG_tandPdgenums in modified files to make the code more readable, unless you already know all the PDG codes ;)