Open
Conversation
-IBD partition -Fixed missing g in alphapartdropgroup() -removed centre=FALSE
- column names - handling multiple traits
- multiple traits with IBD partitioning
- test for IBD (single trait) - commenting break downs the theory
Member
|
This looks very impressive @RosCraddock !!!!! I have to finish a couple of other bits, so will lag with the review. |
- First draft of ibd vignette to demonstrate ibd partitioning in AlphaPart. - minor update to c++ code.
Small update in error handling for ibd. Otherwise, an error would be flagged unnecessarily. Tested and working on real data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code completed for implementing gametic/ibd partitioning in R.
Tested on one and multiple traits locally. Implemented test for single and multiple traits.
All other testing passed through test_that.
Addressing issue #18