Make developer app address lookups case-insensitive#762
Open
rickyrombo wants to merge 2 commits intomainfrom
Open
Make developer app address lookups case-insensitive#762rickyrombo wants to merge 2 commits intomainfrom
rickyrombo wants to merge 2 commits intomainfrom
Conversation
Use lower() on both sides of the address comparison in GetDeveloperApps and GetDeveloperAppsWithGrants queries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the developer app retrieval queries to treat app addresses as case-insensitive, preventing lookup failures when callers provide mixed-case addresses.
Changes:
- Made
GetDeveloperAppsaddress matching case-insensitive by applyinglower()to both sides of the comparison. - Made
GetDeveloperAppsWithGrantsaddress matching case-insensitive by applyinglower()to both sides of the comparison. - Regenerated the sqlc Go output to reflect the updated SQL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| api/dbv1/queries/get_developer_apps.sql | Updates address predicates to be case-insensitive for both developer app listing and grants-based listing queries. |
| api/dbv1/get_developer_apps.sql.go | sqlc-generated Go update reflecting the modified SQL query text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/AudiusProject/api/sessions/9df9ff3f-61bc-492a-bfde-45791942537c Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lower()on both sides of the address comparison inGetDeveloperAppsandGetDeveloperAppsWithGrantsSQL queries0x-prefixed vs bare hex)Test plan
🤖 Generated with Claude Code