Fix Image.clip_to_dtype and Image.astype with Dask arrays#44
Merged
Fix Image.clip_to_dtype and Image.astype with Dask arrays#44
Image.clip_to_dtype and Image.astype with Dask arrays#44Conversation
Image.clip_to_dtype when using Dask arraysImage.clip_to_dtype and Image.astype when using Dask arrays
Image.clip_to_dtype and Image.astype when using Dask arraysImage.clip_to_dtype and Image.astype when using Dask arrays
Image.clip_to_dtype and Image.astype when using Dask arraysImage.clip_to_dtype and Image.astype with Dask arrays
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes compatibility issues with Dask arrays in the Image.clip_to_dtype and Image.astype methods by introducing helper functions that handle both NumPy and Dask array types appropriately.
- Introduces
_get_min_max_values()helper function to efficiently compute min/max values for both NumPy and Dask arrays - Introduces
_unique()helper function to compute unique values for both NumPy and Dask arrays - Adds comprehensive test coverage for Dask arrays by creating new test classes that inherit from mixin classes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
giatools/image.py |
Adds _get_min_max_values() and _unique() helper functions; updates astype() and clip_to_dtype() methods to use these helpers instead of calling array methods directly |
tests/unit/test__image.py |
Adds mocks for new helper functions to ensure unit tests remain isolated |
tests/module/test__image.py |
Refactors test structure with mixins to enable testing both NumPy and Dask arrays; adds ImageTestCase__dtype_mixin__dask class and separate test classes for Dask array testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Test coverage results for ac17eb1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.