Conversation
|
Thank you! I know virtually nothing of It appears not to have broken the AppVeyor builds (which use |
|
Thanks. There are a couple more things to fix (include paths etc.), so don't merge it now. |
- add scopes to target_link_libraries - add pdcurses_include_dirs interface target
|
Ok, seems to be working now, and CI is fine. By the way, is there any reason to have PDC_SDL2_BUILD, PDC_SDL2_DEPS_BUILD & PDC_GL_BUILD enabled by default? |
|
@juliusikkala @neko-para @jwinarske Can someone of you have a look at this PR? Note: I also think that the SDL + GL parts should be optional (needs an adjustment to appveyor.yml when conditional) |
There was a problem hiding this comment.
Looks good to me, and I also agree that SDL + GL should be optional.
Although, it looks like I'm not able to build the project on my system anymore (OpenSUSE Tumbleweed). It's been a while since I last worked on my PDCursesMod-dependent project. I don't think these problems are caused by this PR; in fact, this removes some of the errors I see when trying to build master, so that's a good sign at least. It looks like the SDL & zlib deps need to be updated, as the old versions appear to not work with newer CMake versions that broke compatibility with CMake < 3.5. But that's not something that has to be dealt with in this PR, so I opened a new separate PR for updating those.
|
@Bill-Gray if you happen to be online, please cancel all older Appveyor builds as these take very long - and while I can start them with a push to a branch or by allowing the workflow to run, I can't do anything on Appveyor itself (if you want to, you should be able to adjust that at https://ci.appveyor.com/team) |
Replace
CMAKE_SOURCE_DIRwith relative path counterparts.These changes should allow using the library as an external dependency with the
FetchContent, as for that caseCMAKE_SOURCE_DIRpoints to the top-level CMakeLists.txt.