fix(sdk-coin-sol): add early validation for transaction size limits#7789
Open
nvrakesh06 wants to merge 1 commit intomasterfrom
Open
fix(sdk-coin-sol): add early validation for transaction size limits#7789nvrakesh06 wants to merge 1 commit intomasterfrom
nvrakesh06 wants to merge 1 commit intomasterfrom
Conversation
nvrakesh06
force-pushed
the
WIN-8401-1
branch
2 times, most recently
from
3682a3b to
8af5ae6
Compare
nvrakesh06
force-pushed
the
WIN-8401-1
branch
from
8af5ae6 to
e2c71f5
Compare
Contributor
Author
Contributor
|
can there be a transaction which has both the cases of with and without ata creation? |
Contributor
Author
|
@at31416 good catch, you’re right, I completely missed that case. If we start explicitly handling every edge case here, it’ll quickly get messy and hard to maintain. I’m leaning towards letting the Solana SDK surface the error as-is (since it’s the source of truth). Do you think we should keep it that way, or wrap it in a higher-level BitGo error with a cleaner message/context? |
Contributor
imo we should wrap it in a cleaner error message if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-8401
Add transaction size validation to prevent buffer overflow errors when sending to too many recipients