fix audio indices and update Quirks layout#800
Merged
SergeySlice merged 3 commits intoCloverHackyColor:masterfrom Feb 17, 2026
Merged
fix audio indices and update Quirks layout#800SergeySlice merged 3 commits intoCloverHackyColor:masterfrom
SergeySlice merged 3 commits intoCloverHackyColor:masterfrom
Conversation
- Corrected Audio selection index in SubMenuAudioPort (119 -> 118) - Updated GUI handling in REFIT_MENU_SCREEN.cpp for DSDT (116 -> 115) and Audio (119 -> 118) - Removed broken bitmask (& 0x2F) for audio output index in ApplyInputs - Ensured kext blocking logic remains untouched This resolves the UI hang when selecting audio outputs and allows correct saving of sound and DSDT settings to NVRAM.
Fix GUI indices for Audio and DSDT, and remove broken audio mask
## Description
This PR provides a comprehensive fix for audio selection issues in the Clover GUI and synchronizes the Quirks menu with the current `config.plist` structure.
### 🐞 Bug Fixes
* **Audio Selection & UI Hangs:**
* Fixed incorrect index mapping in `menu.cpp` (shifted from 119 to 118).
* Updated `REFIT_MENU_SCREEN.cpp` with correct IValue IDs (`115` for DSDT, `118` for Audio) to ensure selection events are processed.
* Removed a faulty `& 0x2F` bitmask in `ApplyInputs` that was truncating audio indices on multi-output systems.
### ⚙️ Quirks Menu Improvements
* **Sync with config.plist:** Reorganized the Quirks menu to match the exact order of the configuration file.
* **New Parameters:** Added all missing quirks (e.g., `AppleXcpmExtraMsrs`, `ForceOcWriteFlash`, `SignalAppleOS`).
* **Refactoring:** Moved `XhciPortLimit` and `ProvideCurrentCpuInfo` from "Binaries patching" to the Quirks menu for structural consistency.
* **Scalability:** Increased `InputItems` array size to `200` to support the expanded list of settings.
### 🧪 Impact
* Resolves reported UI freezes when interacting with audio settings.
* Ensures kext blocking and all quirks are correctly indexed and functional via `FillInputs`/`ApplyInputs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a comprehensive fix for audio selection issues in the Clover GUI and synchronizes the Quirks menu with the current
config.pliststructure.🐞 Bug Fixes
menu.cpp(shifted from 119 to 118).REFIT_MENU_SCREEN.cppwith correct IValue IDs (115for DSDT,118for Audio) to ensure selection events are processed.& 0x2Fbitmask inApplyInputsthat was truncating audio indices on multi-output systems.⚙️ Quirks Menu Improvements
AppleXcpmExtraMsrs,ForceOcWriteFlash,SignalAppleOS).XhciPortLimitandProvideCurrentCpuInfofrom "Binaries patching" to the Quirks menu for structural consistency.InputItemsarray size to200to support the expanded list of settings.🧪 Impact
Type of change
Checklist
Additional information
FillInputs/ApplyInputs.