feat: Dependency upgrades, javafx version bump, upgrade to jdk 24#145
Merged
CodeDead merged 5 commits intodevelopmentfrom Apr 27, 2025
Merged
feat: Dependency upgrades, javafx version bump, upgrade to jdk 24#145CodeDead merged 5 commits intodevelopmentfrom
CodeDead merged 5 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project's dependency on Java by bumping the JDK version from 23 to 24 in the GitHub workflow files.
- Updated JDK version to 24 in the test workflow
- Updated JDK version to 24 in the release workflow
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Upgraded JDK from version 23 to 24 in test jobs |
| .github/workflows/release.yml | Upgraded JDK from version 23 to 24 in release jobs (applied twice) |
Files not reviewed (5)
- gradle/gradle-daemon-jvm.properties: Language not supported
- gradle/wrapper/gradle-wrapper.properties: Language not supported
- gradlew: Language not supported
- gradlew.bat: Language not supported
- settings.gradle: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades various project dependencies, bumps the JavaFX version, and updates the JDK version from 23 to 24.
- Removed the redundant "requires java.base" declaration from module-info.java
- Updated the logger message in HelpUtils.java for added context
- Removed the JDK 23 setup steps in GitHub workflows, implying an upgrade to JDK 24
Reviewed Changes
Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/module-info.java | Removed the explicit java.base requirement (redundant in modules) |
| src/main/java/com/codedead/opal/utils/HelpUtils.java | Updated log message to provide additional details about file opening |
| .github/workflows/test.yml | Removed JDK 23 setup steps; verify if a JDK 24 setup is needed |
| .github/workflows/release.yml | Removed JDK 23 setup steps; verify if a JDK 24 setup is needed |
Files not reviewed (7)
- .AppImage/createAppImage.sh: Language not supported
- gradle/gradle-daemon-jvm.properties: Language not supported
- gradle/wrapper/gradle-wrapper.properties: Language not supported
- gradlew: Language not supported
- gradlew.bat: Language not supported
- settings.gradle: Language not supported
- src/main/resources/translations/OpalApplication_uk_UA.properties: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/test.yml:23
- The PR title indicates an upgrade to JDK 24, but the workflow no longer sets up a JDK version. Consider adding a setup step for JDK 24 to ensure the tests run with the intended Java version.
- - name: Setup JDK 23
.github/workflows/release.yml:23
- The removal of the JDK 23 setup steps needs to be complemented with a step for JDK 24 as per the PR purpose. Update the release workflow accordingly to maintain consistency with the upgraded JDK version.
- - name: Setup JDK 23
src/main/java/com/codedead/opal/utils/HelpUtils.java:39
- [nitpick] Ensure that the updated log message 'from filesystem' accurately reflects the behavior of runnableFileOpener, as it may be misleading if files are sourced differently.
logger.info("Attempting to open file from filesystem {}", runnableFileOpener.getFileLocation());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.