Glasgow | Prati Amalden | Module Complexity | Sprint 2 | precomputing#64
Open
PratiAmalden wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Glasgow | Prati Amalden | Module Complexity | Sprint 2 | precomputing#64PratiAmalden wants to merge 1 commit intoCodeYourFuture:mainfrom
PratiAmalden wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
PratiAmalden
added
the
Needs Review
cjyuan
reviewed
Feb 15, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
There is another exercise in the count_letters folder.
Comment on lines
+22
to
+24
| max_len = min(len(s1), len(s2)) | ||
| while prefix_len < max_len and s1[prefix_len] == s2[prefix_len]: | ||
| prefix_len += 1 |
There was a problem hiding this comment.
Why not just use the provided function, find_common_prefix()?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.