Sheffield |26-ITP-jan| Seti Mussa | Sprint 1 | Wireframe#1051
Open
Seti-Jemal wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
Sheffield |26-ITP-jan| Seti Mussa | Sprint 1 | Wireframe#1051Seti-Jemal wants to merge 7 commits intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Jan 29, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Page looks nice and code is free of error. Good job.
- Can you update the Changelist section in the PR description?
- Can you improve the indentation of the HTML code?
Wireframe/index.html
Outdated
Comment on lines
48
to
50
| <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches"> | ||
| Read more about Git branches | ||
| </a> |
Contributor
There was a problem hiding this comment.
The indentation of some of the code can use some improvement.
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.
cjyuan
added
Reviewed
Seti-Jemal
added
the
Needs Review
Contributor
|
Did you forget to push your changes to GitHub? There isn't any new commits on this PR branch. |
cjyuan
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
Contributor
|
Looks good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I added articles with images and links to the wireframe.