-
-
Notifications
You must be signed in to change notification settings - Fork 419
Manchester | ITP Jan-2026 | Ofonime Edak| Sprint 2 | Form Control #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Have you tried submitting the form to ensure it behaves as expected?
- If any value is omitted, the form won't submit
- If all input are valid, then the form can be submitted successfully
-
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the
patternattribute to disallow any name that contains only space characters?
Form-Controls/index.html
Outdated
| <select name="size" id="size"> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Spec asks for 6 different sizes.
-
There is a way to configure a
<select>element so that no option is selected by default, allowing the user to make an explicit choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Cjyuan, for your feedback. I have done the correction, but I think checking the validator is not working because the URL is not public, and the github Url contains other HTML files
Ofonimeedak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR updated
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job in addressing some of my comments.
However, there are still errors in your code, can you fix them?
Suggestion: Use an AI tool to help you check errors, typo, consistency, accessibility, and suggest possible improvements.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is free of syntax error and well indented. All requirements met. Well done.
| <input | ||
| type="radio" | ||
| id="blue" | ||
| value="Blue" | ||
| name="color" | ||
| required | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
When we wrap the radio button input inside
<label>, assigning anidto the input element is optional. -
Among the radio buttons in the same button group (same
nameattribute value), it is not necessary to introduce multiplerequired.
|
Can you format the PR description in proper Markdown syntax so that it look like this: Self checklist
ChangelistForm control using HTML only, to create a form for a T-shirt vendor |
|
The checkboxes are not yet formatted correctly in Markdown syntax. The Wireframe implementation is good. Well done. |

Self checklist
Change List
-[x] My form is semantic HTML.
-[x] All inputs have associated labels.
-[x] My Lighthouse Accessibility score is 100.
-[x] I require a valid name. I have defined a valid name as a text string of two characters or more.
-[x] I require a valid email.
-[x] I require one colour from a defined set of 3 colours.
-[x] I require one size from a defined set of 6 sizes.
-[x] proper use of markdown
Form control using HTML only, to create a form for a T-shirt vendor for the following sizes
XS, S, M, L, XL, XXL
Style Guide
This code follows the style guide as included in the success criteria style-guide.
-[x] Correct use of semantic tags
-[x] Light house analysis with 100% accessibility score.
-[x] Use of labels to improve readability
Form Validation
-[x] Form input name field validation using regExp pattern attribute
-[x] radio buttons using the same name attribute across all buttons
-[x] Label on the select options to give a non-default item select
-[x] required, email attribute on email to ensure the correct email format is entered.
Testing
-[x] Take out each field and submit to see if the form submits
-[x] Entered characters without @ on the email to check if it can submit
-[x] Entered a non-alphabet character and a character less than 2 to test the pattern attribute
-[x] Validate HTML using the validator website
Changes