Skip to content

Conversation

@Ofonimeedak
Copy link

@Ofonimeedak Ofonimeedak commented Jan 24, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the [style guide]

Change List
-[x] My form is semantic HTML.
-[x] All inputs have associated labels.
-[x] My Lighthouse Accessibility score is 100.
-[x] I require a valid name. I have defined a valid name as a text string of two characters or more.
-[x] I require a valid email.
-[x] I require one colour from a defined set of 3 colours.
-[x] I require one size from a defined set of 6 sizes.
-[x] proper use of markdown

Form control using HTML only, to create a form for a T-shirt vendor for the following sizes
XS, S, M, L, XL, XXL

Style Guide
This code follows the style guide as included in the success criteria style-guide.
-[x] Correct use of semantic tags
-[x] Light house analysis with 100% accessibility score.
-[x] Use of labels to improve readability
Form Validation
-[x] Form input name field validation using regExp pattern attribute
-[x] radio buttons using the same name attribute across all buttons
-[x] Label on the select options to give a non-default item select
-[x] required, email attribute on email to ensure the correct email format is entered.

Testing
-[x] Take out each field and submit to see if the form submits
-[x] Entered characters without @ on the email to check if it can submit
-[x] Entered a non-alphabet character and a character less than 2 to test the pattern attribute
-[x] Validate HTML using the validator website

Changes

  • text input, adding regExp
  • encapsulating input in a label tag for accessibility
  • Rewriting work description

@github-actions

This comment has been minimized.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e2566b6
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69828eaaa9afa5000809e4e7
😎 Deploy Preview https://deploy-preview-1057--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ofonimeedak Ofonimeedak added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 24, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 2, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • Have you tried submitting the form to ensure it behaves as expected?

    • If any value is omitted, the form won't submit
    • If all input are valid, then the form can be submitted successfully
  • Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

Comment on lines 51 to 57
<select name="size" id="size">
<option value="xs">XS</option>
<option value="s">S</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spec asks for 6 different sizes.

  • There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Cjyuan, for your feedback. I have done the correction, but I think checking the validator is not working because the URL is not public, and the github Url contains other HTML files

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 2, 2026
Copy link
Author

@Ofonimeedak Ofonimeedak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 2, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in addressing some of my comments.

However, there are still errors in your code, can you fix them?

Suggestion: Use an AI tool to help you check errors, typo, consistency, accessibility, and suggest possible improvements.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax error and well indented. All requirements met. Well done.

Comment on lines +56 to +62
<input
type="radio"
id="blue"
value="Blue"
name="color"
required
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When we wrap the radio button input inside <label>, assigning an id to the input element is optional.

  • Among the radio buttons in the same button group (same name attribute value), it is not necessary to introduce multiple required.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 7, 2026

Can you format the PR description in proper Markdown syntax so that it look like this:


Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Form control using HTML only, to create a form for a T-shirt vendor

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 12, 2026

The checkboxes are not yet formatted correctly in Markdown syntax.
Since Markdown are widely used on GitHub, I would strongly suggest reading this article.

The Wireframe implementation is good. Well done.

@cjyuan cjyuan removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 12, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. and removed Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants