generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 420
Glasgow | ITP January-2026| Tuan Nguyen | Sprint 2| Form control #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jacknguyen4438
wants to merge
14
commits into
CodeYourFuture:main
Choose a base branch
from
Jacknguyen4438:Form-control-work
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−21
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e8bbf03
Creating and adding input for the user
Jacknguyen4438 6ab6dd5
Doing required check on task need to be done
Jacknguyen4438 2b6606d
Nesting select and option inside the parent label to help with acces…
Jacknguyen4438 ee353eb
Doing some attribute to some input and adding check to learning object
Jacknguyen4438 e6ac02a
Merge branch 'CodeYourFuture:main' into Form-control-work
Jacknguyen4438 5e42f93
Making some improvement after reading some review comment. Fix some e…
Jacknguyen4438 7b5e8cc
Merge branch 'Form-control-work' of https://github.com/Jacknguyen4438…
Jacknguyen4438 8d1277c
Remove comment for easier reading, changing the footer tags for bette…
Jacknguyen4438 205ba3b
fixing some grammar error and change fit with the course work criteria
Jacknguyen4438 9c5a249
Small change to the radio button
Jacknguyen4438 7ec34c7
adding require attribute to radio input
Jacknguyen4438 978ad11
Make some change to for attribute and it value lower case.
Jacknguyen4438 9d9847f
Make some change for the rest of all attribute value.
Jacknguyen4438 ba8b66c
minor change some id and label link
Jacknguyen4438 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <title>Glasgow style product form</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
|
|
@@ -13,15 +13,44 @@ <h1>Product Pick</h1> | |
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Customer name:</label> | ||
| <input type="text" id="name" name="name" required placeholder="john smith"> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <label for="email">Customer email:</label> | ||
| <input type="email" id="email" name="email" required placeholder="[email protected]"> | ||
| </div> | ||
| <br> | ||
| <fieldset> | ||
| <legend>Pick a color of your choosing</legend> | ||
| <input type="radio" id="color-red" name="color" value="red" required> | ||
| <label for="color-red">Red</label> | ||
| <input type="radio" id="color-blue" name="color" value="blue" required> | ||
| <label for="color-blue">Blue</label> | ||
| <input type="radio" id="color-green" name="color" value="green" required> | ||
| <label for="color-green">Green</label> | ||
| </fieldset> | ||
| <div> | ||
| <br> | ||
| <label for="size">Shirt size</label> | ||
| <select id="size" name="shirt size" required> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <br> | ||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </main> | ||
| <hr> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <p><strong>By Tuan Nguyen</strong></p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review the exercise requirements? Should there be changes in the README file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have check the criteria and make some change. I am happy report that the change now fit with the course check list.