London | 26-ITP-Jan | Alex Okorefe | Sprint 2 | Form controls#1128
Open
Alex-Os-Dev-Lab wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Alex Okorefe | Sprint 2 | Form controls#1128Alex-Os-Dev-Lab wants to merge 7 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
…ghthouse accessibility score
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Alex-Os-Dev-Lab
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Alex-Os-Dev-Lab
added
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Alex-Os-Dev-Lab
added
the
Needs Review
SlideGauge
added
the
Review in progress
SlideGauge
suggested changes
Feb 6, 2026
Form-Controls/index.html
Outdated
| </div> | ||
| <br> | ||
|
|
||
| </section> |
There was a problem hiding this comment.
Please, notice when this tag is opened, and where it closes (note how tags are nested)
Form-Controls/index.html
Outdated
|
|
||
| </div> | ||
|
|
||
| <!-- T-Shirt Size Selection: |
There was a problem hiding this comment.
Comment indentation is inconsistent with the div tag it comments
Form-Controls/index.html
Outdated
| <fieldset> | ||
| <legend>*T-Shirt Colour:</legend> | ||
| <label for="ColourRed">Red</label> | ||
| <input type="radio" id="ColourRed" name="T-ShirtColourSelection" value="Red" required> |
There was a problem hiding this comment.
Typically radio button is placed to the left from the text it refers to
Form-Controls/index.html
Outdated
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <!-- |
There was a problem hiding this comment.
Comment indentation is inconsistent with the div below
SlideGauge
added
Reviewed
…tions, enhancing customer information section, and ensuring required fields are clearly marked. placed radio buttons to the left of text
Alex-Os-Dev-Lab
added
Needs Review
oyagbileoluwaseun
added
Review in progress
oyagbileoluwaseun
suggested changes
Feb 12, 2026
Form-Controls/index.html
Outdated
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By ALEX OKOREFE</h2> |
There was a problem hiding this comment.
Great work. What do you think about using the h2 tag for at the footer? Can another, more appropriate tag be used?
| </select> | ||
| </fieldset> | ||
| </div> | ||
| </section> |
There was a problem hiding this comment.
For a form to be submitted, even though we aren't using JavaScript. Do you think a button is missing at the end used to submit a form. Let me know your thoughts on this, or what you think you can add to improve it.
Form-Controls/index.html
Outdated
|
|
||
| <div> | ||
| <fieldset> | ||
| <legend>*T-Shirt Colour:</legend> |
There was a problem hiding this comment.
Alex, well done using the required to enforce users responding. Do you think putting like a required in bracket would be cleaner than the * used.
oyagbileoluwaseun
added
Reviewed
…submit button included
Alex-Os-Dev-Lab
added
Needs Review
Author
|
Hello Oyagbile,
Thank you for the feedback. I have implemented the suggested changes, and I hope they meet the requirements.
I apologize for the follow-up, but would you be able to review and mark the assignment as complete if the changes are satisfactory? My continuation in the program is contingent on this submission, and I believe the deadline is today.
Many thanks,
Alex
________________________________
From: Oyagbile Oluwaseun ***@***.***>
Sent: 12 February 2026 23:59
To: CodeYourFuture/Module-Onboarding ***@***.***>
Cc: Alex-Os-Dev-Lab ***@***.***>; Author ***@***.***>
Subject: Re: [CodeYourFuture/Module-Onboarding] London | 26-ITP-Jan | Alex Okorefe | Sprint 2 | Form controls (PR #1128)
@oyagbileoluwaseun requested changes on this pull request.
Form controls
________________________________
In Form-Controls/index.html<#1128 (comment)>:
</form>
</main>
<footer>
<!-- change to your name-->
- <h2>By HOMEWORK SOLUTION</h2>
+ <h2>By ALEX OKOREFE</h2>
Great work. What do you think about using the
tag for at the footer? Can another, more appropriate tag be used?
________________________________
In Form-Controls/index.html<#1128 (comment)>:
+ <div>
+ <fieldset>
+ <legend>*T-Shirt Size:</legend>
+ <label for="TShirtSize">Select Size:</label>
+ <select id="TShirtSize" name="TShirtSize" required>
+ <option value="">-- Select your size --</option>
+ <option value="XS">XS</option>
+ <option value="S">S</option>
+ <option value="M">M</option>
+ <option value="L">L</option>
+ <option value="XL">XL</option>
+ <option value="XXL">XXL</option>
+ </select>
+ </fieldset>
+ </div>
+ </section>
For a form to be submitted, even though we aren't using JavaScript. Do you think a button is missing at the end used to submit a form. Let me know your thoughts on this, or what you think you can add to improve it.
Well done Alex.
________________________________
In Form-Controls/index.html<#1128 (comment)>:
+ <br />
+ </section>
+
+ <section>
+ <h2>T-Shirt Selection:</h2>
+
+ <p>Select your preferred T-shirt colour and size:</p>
+
+ <!-- T-Shirt Colour Selection:
+ - type = "radio" for selection mandatory one choice
+ - field is required
+ -->
+
+ <div>
+ <fieldset>
+ <legend>*T-Shirt Colour:</legend>
Alex, well done using the required to enforce users responding. Do you think putting like a required in bracket would be cleaner than the * used.
—
Reply to this email directly, view it on GitHub<#1128 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B42Z7BL5JTSET7TEMKN6VWT4LUHWZAVCNFSM6AAAAACT3NLSUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOOJUGMYDSNJTGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
I have no questions at the moment.