Skip to content

Cape Town |2026-ITP- Jan| Jacob Tubajiki Menda | Sprint 1 | Wireframe#1130

Open
Jacob-Md wants to merge 22 commits intoCodeYourFuture:mainfrom
Jacob-Md:wires
Open

Cape Town |2026-ITP- Jan| Jacob Tubajiki Menda | Sprint 1 | Wireframe#1130
Jacob-Md wants to merge 22 commits intoCodeYourFuture:mainfrom
Jacob-Md:wires

Conversation

@Jacob-Md
Copy link

@Jacob-Md Jacob-Md commented Feb 4, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This wireframe webpage was created for Sprint 1 and includes three questions with descriptive images. The project was built using HTML and styled with CSS.

Questions

Could you please review my code and let me know if any changes are needed?

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0978e78
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698f848a950cfb0008dd074e
😎 Deploy Preview https://deploy-preview-1130--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Jacob-Md Jacob-Md added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 4, 2026
@github-actions

This comment has been minimized.

@Jacob-Md Jacob-Md added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@github-actions

This comment has been minimized.

@Jacob-Md Jacob-Md added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@Jacob-Md Jacob-Md added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@Jacob-Md Jacob-Md added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@Jacob-Md Jacob-Md changed the title Cape Town |2026-ITP- January| Jacob Tubajiki Menda | Sprint 1 | Wireframe Cape Town |2026-ITP- Jan| Jacob Tubajiki Menda | Sprint 1 | Wireframe Feb 4, 2026
@github-actions

This comment has been minimized.

@Jacob-Md Jacob-Md added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 4, 2026
@github-actions

This comment has been minimized.

7 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 8, 2026

Your need to replace the placeholder text in both Changelist and Questions sections to pass the validation check.

image

@Jacob-Md Jacob-Md added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 10, 2026

There are a few things you can do to further improve your work.

Can you take a look at this General Feedback to see what you can do to make your PR more robust and ready?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 10, 2026
@Jacob-Md
Copy link
Author

@cjyuan
I have made edits to the Wireframe project. Could you please review the changes and provide your feedback?”

@cjyuan
Copy link
Contributor

cjyuan commented Feb 13, 2026

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • Can you improve the indentation of the code?

  • To better align with the wireframe, can you

    • Align the height of articles 2 and 3
    • Align the left edge of article 1 with the left edge of article 2
    • Align the right edge of article 1 with the right edge of article 3
  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

  • Can you improve the Lighthouse Accessibility Score to 100?

image

@cjyuan
Copy link
Contributor

cjyuan commented Feb 13, 2026

When your PR is ready to be re-reviewed, you should also add the "Needs Review" label in addition to responding to reviewer's feedback. Without this label, the reviewer would not know if your changes is ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants