Skip to content

London | 26-ITP-Jan | Kris Oldrini | Sprint 2 | Form Controls #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XiaoQuark wants to merge 22 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Jan | Kris Oldrini | Sprint 2 | Form Controls #1140

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fcf8527
create 2 more article placeholders
XiaoQuark Jan 31, 2026
9a38079
add project requirements as comments
Feb 5, 2026
6641400
add all base inputs and labels
Feb 5, 2026
1f0a883
add placeholder text and sizes to dropdown
Feb 5, 2026
55610e9
add two more colour options to the radio input
Feb 5, 2026
b5a3bd0
fix: change colored emojis to their Unicode codes as they were not ap…
Feb 5, 2026
f32d653
add fieldsets for a more organised form layout
Feb 5, 2026
75b7ba6
change input:submit to a button:submit. Also re-define id and name or…
Feb 5, 2026
f852b03
wrap labels and their inputs inside <p> tags, for improved layout
Feb 5, 2026
35e4fc6
wrap radio buttons inside list to increase spacing and improve access…
Feb 5, 2026
21b47b9
reintroduce fieldset for better layout
Feb 5, 2026
43d3a77
make all fields required, in particular radio buttons
Feb 5, 2026
4bf9e76
add validation pattern to email input
Feb 5, 2026
6247867
add min length of 2 characters to name input
Feb 5, 2026
66a63ab
add meta description for SEO
Feb 5, 2026
385841d
added placeholder option to select element
Feb 5, 2026
ca28db5
fix: remove pattern for email validation, make the radio buttons lege…
Feb 6, 2026
9a115d7
Merge branch 'feature/form-controls' of https://github.com/XiaoQuark/…
XiaoQuark Feb 7, 2026
31afaa5
remove <p> tags around radio buttons for a cleaner look and use inste…
XiaoQuark Feb 7, 2026
fdb9c41
remove changes in wireframe/index.html so that code matches the main …
XiaoQuark Feb 7, 2026
e158f07
fix: changes <!doctype html> back to <!DOCTYPE html> to resolve pull …
Feb 7, 2026
5556d08
fix: change footer text to paragraph to resolve PR conflict
Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 109 additions & 25 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,111 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta
name="description"
content="Accessible t-shirt order form with colour and size selection."
/>
<title>My form exercise</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>T-shirt Picker</h1>
<p>Please complete all required (*) fields to complete order</p>
</header>
<main>
<form>
<fieldset>
<legend>Customer Info</legend>
<!-- name input, must be min 2 chars long -->
<p>
<label for="name"> Name *</label>
<input
type="text"
id="name"
name="customerName"
placeholder="Jane Smith"
minlength="2"
required
/>
</p>
<!-- email input, must be a valid email format -->
<p>
<label for="email"> Email *</label>
<input
type="email"
id="email"
name="customerEmail"
placeholder="[email protected]"
pattern="^[\w.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$"
required
/>
</p>
</fieldset>
<fieldset>
<legend>Select a colour *</legend>
<!-- colours input, limit to 3 colours only -->
<!-- <p>Please select a colour *</p> -->
<ul>
<li>
<br />
<input
type="radio"
name="colours"
id="red"
value="red"
required
/>
<label for="red"> &#x1F7E5; Red </label>
</li>
<li>
<br />
<input
type="radio"
name="colours"
id="blue"
value="blue"
/>
<label for="blue">&#x1F7E6; Blue </label>
</li>
<li>
<br />
<input
type="radio"
name="colours"
id="yellow"
value="yellow"
/>
<label for="yellow">&#x1F7E8; Yellow </label>
</li>
</ul>
</fieldset>
<fieldset>
<legend>Select a size</legend>
<p>
<!-- size input, limit to 6 sizes: XS, S, M, L, XL, XXL -->
<label for="size">Select a size *</label>
<select name="size" id="size" required>
<option value="" disabled selected>size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</p>
</fieldset>

<!-- submit button -->
<p><button type="submit">Confirm your order</button></p>
</form>
</main>
<footer>
<!-- change to your name-->
<p>Kris Oldrini | CYF: Intro to Programming</p>
</footer>
</body>
</html>