London | 26-ITP-Jan | Boualem Larbi Djebbour | Sprint 1 | wireframe #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated content and structure of the wireframe HTML.
Replaced placeholder image with a new icon image.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
djebsoft
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Removed starter styles and design palette comments. Updated styles for body, header, main, articles, article, and footer.
djebsoft
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
djebsoft
added
the
Needs Review
cjyuan
reviewed
Feb 8, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.
cjyuan
added
Reviewed
Author
|
thank you for reviewing. I completed my style.css file checking with no errors found. I properly enhanced my code indentation using VSCode buily-in format document function. |
djebsoft
added
the
Needs Review
cjyuan
reviewed
Feb 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of syntax error. Well done.
To better match the wireframe, can you
- Layout articles 2 and 3 side by side beneath article 1
- Make the image in each article span the full width of the articles?
- Introduce a border around the READ MORE link
- Make the image in article 1 visible
| background-color: lightyellow; | ||
| text-align: center; | ||
| padding: 0.01rem; | ||
| border-top: 2px solid #aaa; |
Wireframe/style.css
Outdated
| width: 100%; | ||
| background-color: lightyellow; | ||
| text-align: center; | ||
| padding: 0.01rem; |
Contributor
There was a problem hiding this comment.
Can you find out how much space is 0.01rem?
Wireframe/index.html
Outdated
| <main> | ||
| <article> | ||
| <img src="https://www.nicepng.com/png/full/357-3576824_this-free-icons-png-design-of-readme-document.png" alt="" | ||
| style="width: 150px" /> |
Contributor
There was a problem hiding this comment.
Better practice is to separate CSS from HTML and write the CSS code in an external file.
cjyuan
removed
the
Needs Review
Removed inline styles from images for consistency.
Refactor CSS variables and update styles for body and main elements.
Change image and SVG width to 50% and set height to 100%.
Reduced container width and adjusted main padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
making some changes to create webpage.
Questions