Glasgow | 26-ITP-Jan | Joma Alrzini | Sprint 2 | Form- Control #1159
+82
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alrzini2025
added
the
Needs Review
SlideGauge
added
the
Review in progress
SlideGauge
reviewed
Feb 7, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Overall, good form, just a request about name criteria being adjusted.
Form-Controls/index.html
Outdated
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[A-Za-z\s]{2,}" |
There was a problem hiding this comment.
This pattern will block real names like O'connor or Sklodowska-Curie. The initial assignment did not demand letters only.
SlideGauge
added
Reviewed
Alrzini2025
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Alrzini2025
added
the
Needs Review
Author
|
I have made changes, please kindly check it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have followed the PR structure for coursework
Questions
I have no question