Skip to content

Conversation

@Zadri415
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added three articles
Added a responsive layout, header, footer, improved accessibility

Zadri415 added 27 commits May 22, 2025 14:37
Fix links inconsistencies and remove ellipsis in HTML.
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 017eca9
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698cdc329cbb4e0008c269b0
😎 Deploy Preview https://deploy-preview-1168--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Zadri415 Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 10, 2026

The Validation bot expects only modified files in the "Wireframe" folder.
However, there seems to be a "Module-Onboarding" folder in the top-level folder.

Can you delete that folder, make a commit, and push the commit to GitHub? If not, the Validation bot will not allow you to use the "Needs Review" label.

@Zadri415 Zadri415 closed this Feb 10, 2026
@Zadri415 Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@Zadri415 Zadri415 reopened this Feb 10, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@Zadri415 Zadri415 closed this Feb 10, 2026
@Zadri415 Zadri415 reopened this Feb 10, 2026
@Zadri415 Zadri415 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 10, 2026
@jenny-alexander jenny-alexander self-requested a review February 11, 2026 03:03
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 11, 2026
Copy link
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zadri415 - you're wireframe exercise is done quite well. Nice work.

One item for you to review is the style of the the 'Read More' button. If you look at the wireframe exercise, you'll see that the button does not span the entire width of the container. Your button currently does. Can you make the adjustment?

</article>

<article>
<img src="https://i0.wp.com/digitalvarys.com/wp-content/uploads/2019/06/image-6.png?fit=640%2C257&ssl=1" alt="" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <img> tag is missing something important for screen readers. Can you find the empty attribute?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jenny - Thanks for pointing that out. I've added a description to the empty alt attribute.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 11, 2026
@Zadri415 Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@jenny-alexander
Copy link
Contributor

@Zadri415 Thanks for updating the alt text.

There are a few style issues to be corrected in order for your webpage to resemble the wireframe.
Screenshot 2026-02-11 at 8 28 58 PM

@jenny-alexander jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants