-
-
Notifications
You must be signed in to change notification settings - Fork 420
London | 26-ITP-Jan | Zadri Abdule | Sprint 1 | Wireframe #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix links inconsistencies and remove ellipsis in HTML.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The Validation bot expects only modified files in the "Wireframe" folder. Can you delete that folder, make a commit, and push the commit to GitHub? If not, the Validation bot will not allow you to use the "Needs Review" label. |
This comment has been minimized.
This comment has been minimized.
jenny-alexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Zadri415 - you're wireframe exercise is done quite well. Nice work.
One item for you to review is the style of the the 'Read More' button. If you look at the wireframe exercise, you'll see that the button does not span the entire width of the container. Your button currently does. Can you make the adjustment?
Wireframe/index.html
Outdated
| </article> | ||
|
|
||
| <article> | ||
| <img src="https://i0.wp.com/digitalvarys.com/wp-content/uploads/2019/06/image-6.png?fit=640%2C257&ssl=1" alt="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This <img> tag is missing something important for screen readers. Can you find the empty attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jenny - Thanks for pointing that out. I've added a description to the empty alt attribute.
Updated the alt attribute of an image to provide a description.
|
@Zadri415 Thanks for updating the There are a few style issues to be corrected in order for your webpage to resemble the wireframe. |


Learners, PR Template
Self checklist
Changelist
Added three articles
Added a responsive layout, header, footer, improved accessibility