West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 2 | coursework/sprint-2

[alizada-dev]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed the Sprint-2 coursework exercises of the Structuring and Testing Data module.

[magarpratik]

I noticed you've used let here and in most other places. Could we use another keyword which might be a better fit?

[alizada-dev]

I used const instead of let

[magarpratik]

Nice! 👌

Could you also review the other places where let is being used?

For reference, here is the CYF Code Style Guide.

[alizada-dev]

Yes, I reviewed the other exercises and changed let to const here as well: const value = Number(penceString.slice(0, -1)) / 100; which was required.

[magarpratik]

Nice! 👍 I can still see a few places where we can use const. Could you find them?

[alizada-dev]

I changed the lets to consts in the function toPounds(penceString) {} function. Maybe this is the one you mean?

[magarpratik]

Yup! 👍

Could you review this file too?

[alizada-dev]

I believe const is not suitable here:
let hours = Number(time.slice(0, 2));
let minutes = Number(time.slice(3, 5));
let ampm = hours >= 12 ? 'pm' : 'am';

because the variable value changes in the next lines of code. I changed these to const but gave error.

[magarpratik]

I believe one of them can be const because it is not reassigned. Could you work out which one?