Glasgow | 26-ITP-Jan| Martin McLean | Sprint 1 | coursework by mjm-git185 · Pull Request #955 · CodeYourFuture/Module-Structuring-and-Testing-Data

mjm-git185 · 2026-02-10T17:07:23Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

i have compleaed my course work now

WeiTsungCheng · 2026-02-16T01:11:43Z

Sprint-1/1-key-exercises/3-paths.js

Almost correct, Check the range

WeiTsungCheng · 2026-02-16T01:24:21Z

Sprint-1/2-mandatory-errors/4.js

weird indentation

WeiTsungCheng · 2026-02-16T01:26:57Z

Sprint-1/2-mandatory-errors/4.js

The specific time period was not taken into account; it is recommended to conduct some conversion tests for different time periods.

12:xx PM should still be 12:xx
12:xx AM should be 00:xx

another thing is

13.00 should use ":" not "."

WeiTsungCheng · 2026-02-16T01:34:11Z

Sprint-1/3-mandatory-interpret/2-time-format.js

 // For the piece of code above, read the code and then answer the following questions

 // a) How many variable declarations are there in this program?
+//      there are 6 declarations


WeiTsungCheng · 2026-02-16T01:35:27Z

Sprint-1/3-mandatory-interpret/2-time-format.js

why change the length from 8784 to 4

i was trying a bunch of different values to see how it would handle smaller Numbers have changed it back to the original value now tho

Sprint-1/4-stretch-explore/chrome.md

WeiTsungCheng

pls check some mistake

WeiTsungCheng · 2026-02-17T03:00:15Z

Sprint-1/2-mandatory-errors/4.js

12:xx PM should still be 12:xx
12:xx AM should be 00:xx

WeiTsungCheng · 2026-02-17T03:04:34Z

Sprint-1/1-key-exercises/3-paths.js

nice!
almost correct!
Please confirm that one of them is missing a "/"

WeiTsungCheng · 2026-02-18T02:51:26Z

Sprint-1/2-mandatory-errors/4.js

=> not correct , use >=

WeiTsungCheng · 2026-02-18T02:54:42Z

Sprint-1/1-key-exercises/3-paths.js

dir should be '/Users/mitch/cyf/Module-JS1/week-1/interpret'

WeiTsungCheng

almost done just some error

WeiTsungCheng · 2026-02-18T02:56:53Z

Sprint-1/2-mandatory-errors/4.js

another thing is

13.00 should use ":" not "."

mjm-git185 added 4 commits February 7, 2026 16:05

solved first error

ebed26d

sprint 1 course work

3f5aecf

trying to get this approved

a2714eb

compleat

fbdf964

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026

WeiTsungCheng added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026

WeiTsungCheng reviewed Feb 16, 2026

View reviewed changes

Sprint-1/1-key-exercises/3-paths.js Outdated

Copy link

WeiTsungCheng Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost correct, Check the range

WeiTsungCheng reviewed Feb 16, 2026

View reviewed changes

Sprint-1/2-mandatory-errors/4.js Outdated

Copy link

WeiTsungCheng Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indentation

WeiTsungCheng reviewed Feb 16, 2026

View reviewed changes

Sprint-1/4-stretch-explore/chrome.md Outdated Show resolved Hide resolved

WeiTsungCheng added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 16, 2026

i made the edits requested

a7ce6b5

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2026

WeiTsungCheng reviewed Feb 17, 2026

View reviewed changes

WeiTsungCheng removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026

mjm-git185 added 2 commits February 17, 2026 16:03

changes made

90091fd

clock changed too

9ee2adf

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 17, 2026

WeiTsungCheng reviewed Feb 18, 2026

View reviewed changes

Sprint-1/2-mandatory-errors/4.js Outdated

Copy link

WeiTsungCheng Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> not correct , use >=

WeiTsungCheng reviewed Feb 18, 2026

View reviewed changes

Sprint-1/1-key-exercises/3-paths.js Outdated

Copy link

WeiTsungCheng Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dir should be '/Users/mitch/cyf/Module-JS1/week-1/interpret'

WeiTsungCheng reviewed Feb 18, 2026

View reviewed changes

Sprint-1/2-mandatory-errors/4.js

Copy link

WeiTsungCheng Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another thing is

13.00 should use ":" not "."

WeiTsungCheng removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

made the edits you pointed out

0263d62

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 18, 2026

Uh oh!

Conversation

mjm-git185 commented Feb 10, 2026

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WeiTsungCheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WeiTsungCheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments