Glasgow | 26-ITP-Jan| Martin McLean | Sprint 2 | coursework by mjm-git185 · Pull Request #963 · CodeYourFuture/Module-Structuring-and-Testing-Data

mjm-git185 · 2026-02-13T17:46:06Z

Changelist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

my coursework

Edu-Vin · 2026-02-13T20:21:22Z

Sprint-2/1-key-errors/2.js

+
+// // =============> write the error message here
+// /home/martinmclean158/Module-Structuring-and-Testing-Data/Sprint-2/1-key-errors/0.js:8
+//   let str = `${str[0].toUpperCase()}${str.slice(1)}`;


I think the error message is wrong. Try running it again

Edu-Vin · 2026-02-13T20:25:06Z

Sprint-2/2-mandatory-debug/0.js

+// //  =============> write your new code here
+function multiply(a, b) {
+  const result = a * b;
+  console.log(result);


Since there is a console.log of the result outside the function, is there a need for the console.log in the function?

Edu-Vin · 2026-02-13T20:38:29Z

Sprint-2/2-mandatory-debug/2.js

+// =============> yes thay all give 3 
 // Explain why the output is the way it is
-// =============> write your explanation here
+// because the variable is a consrent 


Based on your explanation.

It means if I add const num = 103; to your solution before getLastDigit(), will it return 3 for all the console logs?

You didn't answer this.

@mjm-git185 look at this

// because the variable is a const before the code block when num is called it can't be changed

I think you should study global and local variables and how scope works. It will help you understand this code better

my understanding was that the const out side of the code block was in the global scope and because of that would over ride the local scope of the code block, so when it is run the console.log would pick up the global and ignore the local "num"

If a new variable of the same name is declared within the code block, the code will use that new variable and ignore the global variable. Reason why when you passed num into that function, it used what was passed and not the global num.

Edu-Vin · 2026-02-13T20:43:31Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+    let bmi = weight/(height*height)


Can you explain why you used let instead of const?

Edu-Vin · 2026-02-13T20:58:08Z

Sprint-2/3-mandatory-implement/2-cases.js

 // You will need to come up with an appropriate name for the function
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+function SNAKE_CASE (mesasge){


Does the name of the function follow the appropriate naming convention? Does it explain what the function does?

Edu-Vin · 2026-02-13T21:17:41Z

Sprint-2/4-mandatory-interpret/time-format.js


 // b) What is the value assigned to num when pad is called for the first time?
 // =============> write your answer here
+// "null"


Since totalHours is the value used to call pad for the first time. Try doing a console.log to be sure it is null

mjm-git185 · 2026-02-14T12:18:54Z

i have made the changes needed

Edu-Vin · 2026-02-14T20:24:24Z

i have made the changes needed

I can't find the changes you made.

Edu-Vin · 2026-02-14T20:35:43Z

You are supposed to make your changes to this pull request. @mjm-git185

mjm-git185 · 2026-02-14T20:37:07Z

i edited them on vs code and pushed them to git-hub

Edu-Vin · 2026-02-14T20:40:08Z

i edited them on vs code and pushed them to git-hub

From your VS Code, you are supposed to checkout to this branch mjm-git185:Coureswork_Sprint-2, make your changes and push

mjm-git185 · 2026-02-14T20:48:57Z

i have pushed it up and the version i can see is the most recent one #7bc1235

Edu-Vin · 2026-02-14T21:07:38Z

i have pushed it up and the version i can see is the most recent one #7bc1235

Seen

mjm-git185 · 2026-02-14T21:22:07Z

that one has the revisions

mjm-git185 added 4 commits February 13, 2026 17:08

first folder redone

b4198c8

second one done

bd9746a

third times the charm

f3643c1

last one

cae3827

This comment has been minimized.

Sign in to view

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026

This comment has been minimized.

Sign in to view

should all be good this time

0e24e1b

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026

Edu-Vin suggested changes Feb 13, 2026

View reviewed changes

Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 13, 2026

mjm-git185 added 2 commits February 14, 2026 10:21

changed answer to q, B

588adc5

errors fixed

7bc1235

mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026

mjm-git185 requested a review from Edu-Vin February 14, 2026 12:19

Edu-Vin approved these changes Feb 14, 2026

View reviewed changes

Uh oh!

Conversation

mjm-git185 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjm-git185 commented Feb 14, 2026

Uh oh!

Edu-Vin commented Feb 14, 2026

Uh oh!

Edu-Vin commented Feb 14, 2026

Uh oh!

mjm-git185 commented Feb 14, 2026

Uh oh!

Edu-Vin commented Feb 14, 2026

Uh oh!

mjm-git185 commented Feb 14, 2026

Uh oh!

Edu-Vin commented Feb 14, 2026

Uh oh!

mjm-git185 commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mjm-git185 commented Feb 13, 2026 •

edited

Loading