London | 26-ITP-Jan | Zadri Abdule | Sprint 1 | Coursework#964
Open
Zadri415 wants to merge 24 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Zadri Abdule | Sprint 1 | Coursework#964Zadri415 wants to merge 24 commits intoCodeYourFuture:mainfrom
Zadri415 wants to merge 24 commits intoCodeYourFuture:mainfrom
Conversation
Zadri415
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Zadri415
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Zadri415
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Zadri415
added
Needs Review
Edu-Vin
added
Review in progress
Edu-Vin
suggested changes
Feb 13, 2026
There was a problem hiding this comment.
I think you need to recheck the requirements and see if your code solves the problem
There was a problem hiding this comment.
I think you need to recheck the requirements and see if your code solves the problem
This has not been resolved. doa console.log for the dir and ext variables. Does your code run without an error?
There was a problem hiding this comment.
@Zadri415 you haven't resolved this. Look into the lastDotIndex you have on the ext variable. Also confirm if dir was console logged
There was a problem hiding this comment.
Revisit this file. Solution was not provided. Remove unnecessary code
Author
There was a problem hiding this comment.
Thanks for pointing that out. I've made the changes that were suggested.
Edu-Vin
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Completed all of the tasks for Sprint 1 of Module Structuring & Testing Data.