London | SDC-Nov-25 | Emiliano Uruena | Sprint 3 | Implement Shell Tools

[Emilianouz]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Implementing common shell tools so that they behave like the real versions on a typical system: CAT, LS, WC. Node commander was installed to run in every directory.

[LonMcGregor]

Good start on these tasks, I've left some comments for where it could be improved

[LonMcGregor]

Did you mean to make changes to this file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory.

[Emilianouz]

Hi dear @LonMcGregor. I accidentally modified it on main... so, it is in all my branches and PR in this project.

I removed it from this PR and apparently works: ec16d12

But in the next PR I tried to do same, but it was a mess: #235

So, How could I remove securely ?

[LonMcGregor]

Try investigating if you can use the git checkout command. This is very useful as you can specify a branch you want to select specific files from to revert to. For example, you could use the origin/main branch on the number systems file, and this will revert it to the original state in this branch. You would need to do that in each branch affected.

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^implement-shell-tools/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^implement-shell-tools/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.