Skip to content

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 2 | jq#321

Open
katarzynakaz wants to merge 1 commit intoCodeYourFuture:mainfrom
katarzynakaz:jq
Open

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 2 | jq#321
katarzynakaz wants to merge 1 commit intoCodeYourFuture:mainfrom
katarzynakaz:jq

Conversation

@katarzynakaz
Copy link

@katarzynakaz katarzynakaz commented Feb 7, 2026

-->

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

jq.

@katarzynakaz katarzynakaz added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module and removed 📅 Sprint 1 Assigned during Sprint 1 of this module labels Feb 7, 2026
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these tasks, there's just one file you might need to check again.

Also, could you update your pull request description? The description isn't very clear what you have implemented.

# The input for this script is the scores.json file.
# TODO: Write a command to output the names of each player, as well as their city.
# Your output should contain 6 lines, each with two words on it.
[{"name": "Ahmed", "city": "London", "scores": [1, 10, 4]}, {"name": "Basia", "city": "London", "scores": [22, 9, 6]}, {"name": "Mehmet", "city": "Birmingham", "scores": [3, 12, 17]}, {"name": "Leila", "city": "London", "scores": [1]}, {"name": "Piotr", "city": "Glasgow", "scores": [15, 2, 25, 11, 8]}, {"name": "Chandra", "city": "Birmingham", "scores": [12, 6]}]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a comment marker here

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants