Draft
Conversation
- Broaden firebase/php-jwt constraint from ^6.10 to ^6.10 || ^7.0 to maintain BC while supporting the new major version - Update README requirements table to reflect current main branch (Sylius ^2.0, PHP ^8.2) - Add note that Sylius 1.x support is available in plugin version 2.x https://claude.ai/code/session_018f3bgBj7bQd4XmWVDPnDtb
- Add NSS database setup step before BuildTestAppAction to prevent the "failed to install the local Certificate Authority: no Firefox and/or Chrome/Chromium security databases found" mkcert error in CI - Remove firebase/php-jwt from require: it is not used directly anywhere in the plugin source — it is a transitive dependency pulled in via sylius/api-bundle → lexik/jwt-authentication-bundle https://claude.ai/code/session_018f3bgBj7bQd4XmWVDPnDtb
jakubtobiasz
changed the title
firebase/php-jwt dependency
The match expression covers all BlikAliasAction enum cases explicitly (APPLY and REGISTER), making the default arm unreachable. PHPStan correctly flags this as match.alwaysTrue. Remove the redundant default arm to fix the static analysis failure. https://claude.ai/code/session_018f3bgBj7bQd4XmWVDPnDtb
Two bugs were causing "session not created: Chrome instance exited": 1. createPantherClient() was called with [] and a ChromeOptions object as plain array values (integer keys 0/1) inside the first argument, so the options were never applied. Remove the dead ChromeOptions code and call createPantherClient correctly. 2. --disable-gpu was missing from PANTHER_CHROME_ARGUMENTS. This flag is required for stable headless Chrome in CI environments (GitHub Actions / Docker) alongside --disable-dev-shm-usage. https://claude.ai/code/session_018f3bgBj7bQd4XmWVDPnDtb
jakubtobiasz
force-pushed
the
claude/firebase-jwt-7-support-yUlgn
branch
from
cecb359 to
148159e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the plugin to support Sylius 2.0 and PHP 8.2, while maintaining backward compatibility information for users on older versions.
Key Changes
^8.1to^8.2^1.12to^2.02.xof the plugin supports Sylius 1.xfirebase/php-jwtdependency constraint to support both^6.10and^7.0versionsNotable Details
https://claude.ai/code/session_018f3bgBj7bQd4XmWVDPnDtb