fix: dedupe concore/concoredocker shared logic and fix docker path/cleanup behavior#442
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
Conversation
Author
|
Hey @pradeeban 89 tests pass, nothing else touched. Let me know if you want any changes. Also side note the .hpp, .java, and .v pairs probably have the same drift problem, happy to take those next if you want. |
avinxshKD
force-pushed
the
fix/deduplicate-concore-docker
branch
from
8f5c27d to
c254d04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concoredocker.pywas a stale copy ofconcore.pywith bugs. Moved shared logic intoconcore_base.py, both are now thin wrappers, also fixes docker path, ZMQ cleanup, and write() mutating simtimeCloses #436