fix: java init stuck in main and param parser broken for values with =#444
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
fix: java init stuck in main and param parser broken for values with =#444avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban the old fallback was doing replaceAll("=", "':'") which nukes every = in the value... so something like url=https://x.com?a=1 turns into {'url':'https://x.com?a':'1'} and literalEval rightfully throws. split on first = only fixes it, same way parse_params in python already handles it. also moved init out of main() since nobody calls main() when importing the class from another file. Let me know if you want changes in this file or any other Java parts. Goodnight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424
moved init (iport, oport, params, maxtime) from main() into a static {} block so the class actually initializes on load
replaced the broken
replaceAll("=", "':'")fallback with a proper