Skip to content

Comments

fix: java init stuck in main and param parser broken for values with =#444

Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/java-init-and-param-parser
Open

fix: java init stuck in main and param parser broken for values with =#444
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD:fix/java-init-and-param-parser

Conversation

@avinxshKD
Copy link

Fixes #424

moved init (iport, oport, params, maxtime) from main() into a static {} block so the class actually initializes on load
replaced the broken replaceAll("=", "':'") fallback with a proper

  • parseParams() that splits on first = only mirrors
  • concore_base.parse_params
image

@avinxshKD
Copy link
Author

Hey @pradeeban the old fallback was doing replaceAll("=", "':'") which nukes every = in the value... so something like url=https://x.com?a=1 turns into {'url':'https://x.com?a':'1'} and literalEval rightfully throws. split on first = only fixes it, same way parse_params in python already handles it. also moved init out of main() since nobody calls main() when importing the class from another file.

Let me know if you want changes in this file or any other Java parts. Goodnight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant