feat: move settings.json to .config on unix-like systems#808
feat: move settings.json to .config on unix-like systems#808lucaengelhard wants to merge 2 commits intoCyberTimon:mainfrom
Conversation
|
Maybe it also would be a good idea to separate things like lastFolderState into a different file, because that isn't relevant for the config and only store real settings data in the config |
|
On macOS the conventional config location is The If the copy fails silently (the Thanks for your work! EDIT:
Yes! This is a good idea. Let's track this after we completed this PR. |
|
Thanks for the feedback! Tbh i forgot I also opened this PR. I will look into your suggestions |
|
@CyberTimon I updated the code, but I'm not particularly happy with it. Maybe we should put this on the backburner for now as I'm way more focused on and interested in the general refactor of the codebase (#800 and #844) |
Description
Currently the settings are saved next to the program state files on unix-like machines. This PR moves the settings.json file so that it aligns with the .config convention.
Type of Change
Changes Made
Screenshots/Videos
Testing
Test Configuration:
Checklist
Additional Notes
Old settings.json files are automatically moved. Maybe there should be a warning or popup that asks if the user wants the file moved?
Also the folder name is currently hardcoded in. That maybe should be changed?
AI Disclaimer:
Please state the involvement of AI in this PR: