Skip to content

docs: Added initial documentation of hld, lld and erd.#69

Open
mahmoodcli wants to merge 1 commit intomainfrom
feature/HLD-LLD-ERD
Open

docs: Added initial documentation of hld, lld and erd.#69
mahmoodcli wants to merge 1 commit intomainfrom
feature/HLD-LLD-ERD

Conversation

@mahmoodcli
Copy link
Collaborator

No description provided.

### 4.1 End user types

1. **Unauthenticated user (if supported)**
- Accesses public pages and journeys that do not require sign-in.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't supporting unauthenticated users

- Accesses public pages and journeys that do not require sign-in.

2. **Authenticated user (DfE Sign-in)**
- Typical users: school staff and local authority staff.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Multi-Academy Trust executives

PostgreSQL is the system of record for persisted data used by the service. Typical categories include:
- School identity and attributes (e.g., URN, name, address, LA)
- Attributes required for filtering and comparison (phase/type/status)
- Metrics or performance-related values (if stored)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be storing these

1. User selects a school and chooses “compare”
2. Web calls the Compare use-case
3. Application service determines a set of similar schools:
- may be derived via rules and/or Lucene and/or stored relationships (depending on implementation)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a set of pre-calculated stored relationships


1. User requests a protected feature/page
2. Web layer redirects to DfE Sign-in for authentication
3. User returns with identity/claims
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DfE Sign-in returns with identity/claims


### Error handling

- Expected outcomes returned as result objects
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use result objects currently but we probably should do

- **SchoolMetric** (numeric/time-series values used for compare)
- **SimilarSchool** (optional: stored similarity relationships)

If your implementation does not store some of these (e.g., similarity is computed dynamically), remove those entities from this ERD.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think some more about these

- no persistent relationship table exists

This approach avoids circular dependencies in the ERD and reflects the implementation accurately.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rethink this section - there aren't currently any foreign keys in the database, not sure there will be, so there aren't any relational joins. And the database views/tables don't match what's described here

- Fetch from `SCHOOL` and any related tables needed for display:
- characteristics
- metrics
- local authority
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit this, there is no SCHOOL table and the related tables don't match the database

### 6.3 Compare similar schools
- Identify a comparison set:
- from a similarity join table (if stored), or
- derived dynamically via rules/search
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be stored, and not derived dynamically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants