Refactor libspdm interfaces to decouple spdm-emu#3580
Open
itsManjeet wants to merge 1 commit intoDMTF:mainfrom
Open
Refactor libspdm interfaces to decouple spdm-emu#3580itsManjeet wants to merge 1 commit intoDMTF:mainfrom
itsManjeet wants to merge 1 commit intoDMTF:mainfrom
Conversation
itsManjeet
force-pushed
the
libspdm-decouple
branch
3 times, most recently
from
ea37c1d to
a88959c
Compare
This PR refactors parts of the libspdm interface to improve modularity and enable proper decoupling between spdm-emu and libspdm. Currently, spdm-emu relies on internal libspdm components, leading to tight coupling and making it harder to use external libspdm (preferred in external build system like yocto) This change introduces explicit interface boundaries by exporting required components instead of relying on internal linkage. Exported cryptlib_ext, spdm_crypt_lib_ext, libspdm_device_secret_lib to allow used by external tools Signed-off-by: Manjeet Singh <itsmanjeet1998@gmail.com>
itsManjeet
force-pushed
the
libspdm-decouple
branch
from
a88959c to
f3899ee
Compare
Member
|
I think we purposely did not include them in libspdm, because they are NOT consumed by libspdm library. The proposal is to move to the os_stub/include. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors parts of the
libspdminterface to improve modularity and enable proper decoupling betweenspdm-emuandlibspdm. Currently,spdm-emurelies on internallibspdmcomponents, leading to tight coupling and making it harder to use externallibspdm(preferred in external build system like yocto)This change introduces explicit interface boundaries by exporting required components instead of relying on internal linkage.
Exported
cryptlib_ext,spdm_crypt_lib_ext,libspdm_device_secret_libto allow used by external tools.