Skip to content

Add strong warning before permanent item deletion (#5044)#5124

Open
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5044
Open

Add strong warning before permanent item deletion (#5044)#5124
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5044

Conversation

@guillermo-escire
Copy link
Contributor

References

Fixes #5044

Description

Adds a stronger confirmation dialog before permanently deleting an item, warning administrators about irreversible deletion and potential impact on citations and external references.

Instructions for Reviewers

This PR improves the deletion workflow for items by adding a stronger confirmation dialog before permanent deletion.

List of changes in this PR:

  • Added a modal-based confirmation dialog before item deletion.
  • Introduced new i18n translation keys for the deletion warning messages.
  • Displayed a clear warning informing administrators that deletion is permanent and may break external references and scholarly citations.

How to test:

  1. Log in as an administrator.
  2. Navigate to any item and open the edit page.
  3. Click the Delete action.
  4. Verify that a confirmation modal appears with a strong warning message.
  5. Confirm that deletion only proceeds after explicitly confirming in the dialog.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add citation warning before permanent item deletion

1 participant

Comments