Skip to content

[Snyk] Security upgrade eslint from 8.57.1 to 10.0.0#861

Open
Dargon789 wants to merge 1 commit intomainfrom
snyk-fix-946a758b50478f1993b7317417630d78
Open

[Snyk] Security upgrade eslint from 8.57.1 to 10.0.0#861
Dargon789 wants to merge 1 commit intomainfrom
snyk-fix-946a758b50478f1993b7317417630d78

Conversation

@Dargon789
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • packages/google-cloud-servicedirectory/samples/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  803  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

…educe vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-AJV-15274295
@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a critical security update by upgrading the eslint dependency. The primary goal is to mitigate a high-severity Regular Expression Denial of Service (ReDoS) vulnerability, ensuring the project's continued security and stability.

Highlights

  • Security Upgrade: Upgraded the eslint dependency from 8.57.1 to 10.0.0 to address a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295).
Changelog
  • packages/google-cloud-servicedirectory/samples/package.json
    • Updated eslint dependency from ^8.0.0 to ^10.0.0.
Activity
  • This pull request was automatically generated by Snyk to fix a security vulnerability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades eslint from version 8 to 10 to resolve a security vulnerability. While the dependency update is necessary, this is a major version bump that introduces significant breaking changes. As noted in the review comment, the ESLint configuration will likely need to be migrated to the new format to prevent breaking the linting process. This should be addressed before merging.

"dependencies": {
"@google-cloud/service-directory": "^6.1.1",
"eslint": "^8.0.0",
"eslint": "^10.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading eslint from v8 to v10 is a major change that includes significant breaking changes. ESLint v9 introduced a new 'flat' configuration system (eslint.config.js) which is not backward-compatible with the legacy .eslintrc.* format. This upgrade will likely break your linting setup unless the configuration is migrated to the new format.

@snyk-io
Copy link

snyk-io bot commented Feb 14, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Dargon789 Dargon789 linked an issue Feb 16, 2026 that may be closed by this pull request
Dargon789 pushed a commit that referenced this pull request Mar 6, 2026
build: migrate code from googleapis/nodejs-proto-files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#GitHub Actions GKE build-and-deploy workflow

2 participants